Return an integer for AudioFile.samplerate when possible. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psobot
force-pushed
the
psobot/sample-rate-int
branch
from
d2db059
to
9578e0d
Compare
drubinstein
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pedalboard internally represents sample rates as floating-point numbers; however, the vast majority of sample rates used in production are integers (like 44100, 48000, etc).
This PR changes the
AudioFileclass to return an integer for thesamplerateproperty if the fractional part of the sample rate is 0. This will make it possible to do things like passingf.samplerateto thef.readmethod directly, without needing to cast tointfirst.This PR also makes it possible to pass a floating-point number to
AudioFile.read. An exception will be thrown if the provided number has a fractional part.