Add VST3 preset_data property to get/set .vstpreset data directly
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the property has the same behavior as `load_preset` (but doesn't require a file). Getting the property returns the .vstpreset data representing the current plugin state. Previously, it wasn't quite possible to generate .vstpresets purely from `pedalboard` objects, since they need to include a [class ID](https://forum.juce.com/t/how-to-get-vst3-class-id-aka-cid-aka-component-id/41041/3), which isn't exposed elsewhere.
psobot
approved these changes
Jul 30, 2024
| @@ -302,6 +306,59 @@ def test_preset_parameters(plugin_filename: str, plugin_preset: str): | |||
| ), f"Expected attribute {name} to be different from default ({default}), but was {actual}" | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif( | |||
| not AVAILABLE_VST3_PLUGINS_IN_TEST_ENVIRONMENT, | |||
| reason="No VST3 plugin containers installed in test environment!", | |||
There was a problem hiding this comment.
Suggested change
| reason="No VST3 plugin containers installed in test environment!", | |
| reason="No VST3 plugins installed in test environment!", |
|
This is now on PyPI as v0.9.12. Thanks again @kmontag! |
|
Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the property has the same behavior as
load_preset(but doesn't require a file). Getting the property returns the .vstpreset data representing the current plugin state.Previously, it wasn't quite possible to generate .vstpresets purely from
pedalboardobjects, since they need to include a class ID, which isn't exposed anywhere else.(I'm running into issues getting type stubs generated - perhaps someone could generate stubs before merging?)