Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve HighlightJS CSS for JSON #31

Closed
toedter opened this issue Apr 24, 2021 · 2 comments
Closed

Improve HighlightJS CSS for JSON #31

toedter opened this issue Apr 24, 2021 · 2 comments
Labels
type: enhancement
Milestone
0.0.1

Comments

@toedter
Copy link

toedter commented Apr 24, 2021

In dark mode, only white for keys and blue for values,
in light mode everything is black.

It would be great if JSON would be a bit more "colorful", e.g. also render numbers in another color than strings.
@philwebb philwebb changed the title Colors in JSON blocks Improve HighlightJS CSS for JSON Apr 24, 2021
@philwebb philwebb added this to the 0.0.1-RC1 milestone Apr 24, 2021
@philwebb
Copy link
Contributor

Thanks for the suggestion, I've tweaked the CSS a little. It now looks like this:

Screen Shot 2021-04-24 at 12 16 25 PM

It's still not that colorful, but it's closer to the GitHub look:

Screen Shot 2021-04-24 at 12 20 10 PM

@toedter
Copy link
Author

toedter commented Apr 25, 2021

Thx @philwebb

philwebb pushed a commit to philwebb/spring-asciidoctor-backends that referenced this issue Jul 7, 2021
@bclozel
Enable WebSocket endpoint with config property
36121f3 
Prior to this commit, the WebSocket endpoint (MVC or WebFlux) would be
enabled by default. In the case of MVC, the presence of
`spring-websocket` and the required dependencies was an additional hint
that could enable/disable this support depending on the application.

This commit changes the websocket path configuration so that it doesn't
hold a default value anymore. Configuring this property will trigger the
WebSocket support.

Right now developers cannot configure it to be the same as the
`spring.graphql.path`, but this will be solved in spring-io#30.

This commit also revisits the configuration properties namespace for
clarity, moving the websocket bits under their own section.

Closes spring-iogh-31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
0.0.1
Development

No branches or pull requests
2 participants
@philwebb @toedter