Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment in MessageType for readability #973

Closed

Conversation

devholic22
Copy link
Contributor

@devholic22 devholic22 commented Jun 28, 2024

  • Add comment in MessageType for readability
  • fix enum comment grammar

resolved #972

@tzolov
Copy link
Contributor

tzolov commented Jun 28, 2024

Thank you for the improvement @devholic22
Could you please resolve the formatting issue by running the ./mvnw spring-javaformat:apply javadoc:javadoc -Pjavadoc and then squash the 3 commits.

@devholic22
Copy link
Contributor Author

Thank you for the improvement @devholic22 Could you please resolve the formatting issue by running the ./mvnw spring-javaformat:apply javadoc:javadoc -Pjavadoc and then squash the 3 commits.

Thanks for your advice. But even if I keep running the commands you mentioned, I won't get a file that changes. Is there any other way? If there is, I will apply it right away.
Actually, the second commit also applied ./mvnw spring-javaformat:apply.

there is my git status after your command apply.
스크린샷 2024-06-28 오후 7 06 40

@devholic22
Copy link
Contributor Author

@tzolov The cause code is MongoDBAtlasFilterExpressionConverter. I fixed this class comment :)

@tzolov
Copy link
Contributor

tzolov commented Jun 28, 2024

yeh, sorry. i've fixed the other error in c09286e

Could you please rebase your branch, please use git pull -r upstream main not merge, resolve the eventual conflicts and squash the result into a single commit.

* Add comment in MessageType for readability
* fix enum comment grammar
@devholic22
Copy link
Contributor Author

devholic22 commented Jun 28, 2024

Did I correct it well as you intended? I would appreciate it if you could check it :)

and if you have time, please review another my Pull Request about Audio model. thanks!

@tzolov
Copy link
Contributor

tzolov commented Jul 2, 2024

I still can see 2 commits? Did you squashed all commits?

* Add comment in MessageType for readability
* fix enum comment grammar

Add comment in MessageType for readability
@devholic22
Copy link
Contributor Author

I still can see 2 commits? Did you squashed all commits?

I squashed my commits using git rebase command :)

@markpollack
Copy link
Member

There are still 4 commits in this PR. I suggest you make a new PR with one commit that contains the changes you made the the file.

@devholic22
Copy link
Contributor Author

There are still 4 commits in this PR. I suggest you make a new PR with one commit that contains the changes you made the the file.

I understand. you can check in new PR.
Next time, I will squash the commits as you say. I'm sorry for the inconvenience.

@ThomasVitale
Copy link
Contributor

@devholic22 can this PR be closed since the change has been delivered via #1000?

@devholic22 devholic22 closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comment in MessageType for readability
4 participants