Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable management.trace.http by default #15039

Closed
philwebb opened this issue Oct 31, 2018 · 6 comments
Closed

Disable management.trace.http by default #15039

philwebb opened this issue Oct 31, 2018 · 6 comments
Labels
type: enhancement A general enhancement
Milestone
2.2.0.M3

Comments

@philwebb
Copy link
Member

Currently we only offer InMemoryHttpTraceRepository and if actuator is present then we trace every request. This seems a little wasteful so perhaps we should disable support by default.
@philwebb philwebb added the type: enhancement A general enhancement label Oct 31, 2018
@philwebb philwebb added this to the 2.1.x milestone Oct 31, 2018
@philwebb
Copy link
Member Author

See #14966

@philwebb
Copy link
Member Author

Devtools could switch it back on perhaps.

@wilkinsona
Copy link
Member

I'm not sure about changing the default in a maintenance release. Should this not wait for 2.2?

@ayudovin ayudovin mentioned this issue Nov 1, 2018
Closed
@philwebb philwebb modified the milestones: 2.1.x, 2.2.x Nov 1, 2018
@philwebb
Copy link
Member Author

philwebb commented Nov 1, 2018

Whoops, wrong milestone

@philwebb philwebb added the status: pending-design-work Needs design work before any code can be developed label Nov 2, 2018
@philwebb philwebb mentioned this issue Feb 1, 2019
Closed
@bclozel bclozel mentioned this issue Feb 5, 2019
Closed
@vpavic vpavic mentioned this issue Mar 6, 2019
Closed
@philwebb
Copy link
Member Author

philwebb commented May 2, 2019

See also #8679

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label May 3, 2019
@mbhave
Copy link
Contributor

mbhave commented May 3, 2019

We have decided to make the auto-configuration conditional on the presence of a HttpTraceRepository bean instead of auto-configuring an InMemoryTraceRepository. The management.trace.http flag can be used as an opt-out if tracing needs to be disabled even if the bean is present.

@mbhave mbhave closed this as completed in de128fe May 3, 2019
@mbhave mbhave removed for: team-attention An issue we'd like other members of the team to review status: pending-design-work Needs design work before any code can be developed labels May 3, 2019
@mbhave mbhave modified the milestones: 2.2.x, 2.2.0.M3 May 3, 2019
mbhave added a commit that referenced this issue May 3, 2019
@mbhave
Fix tests
e2b15c3 
See gh-15039
@ztomic ztomic mentioned this issue May 9, 2019
Closed
@wilkinsona wilkinsona changed the title Consider disabling management.trace.http by default Disable management.trace.http by default Jun 3, 2019
@wilkinsona wilkinsona mentioned this issue Jun 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.2.0.M3
Development

No branches or pull requests
4 participants
@snicoll @philwebb @wilkinsona @mbhave