Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract duplicated code into a separate method #22404

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Extract duplicated code into a separate method #22404

merged 1 commit into from
Feb 15, 2019

Conversation

stsypanov
Copy link
Contributor

subj

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 11, 2019
@jhoeller
Copy link
Contributor

Looks worthwhile indeed.

Quick side note: There's no need to declare @NonNull explicitly, our core packages are all declared as @NonNullApi at the package level for a non-null default rule.

@jhoeller jhoeller self-assigned this Feb 11, 2019
@stsypanov
Copy link
Contributor Author

@NonNull removed.

@jhoeller jhoeller merged commit d2bfca7 into spring-projects:master Feb 15, 2019
@jhoeller jhoeller added the type: enhancement A general enhancement label Feb 15, 2019
@jhoeller jhoeller added this to the 5.2 M1 milestone Feb 15, 2019
@jhoeller jhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 15, 2019
@stsypanov stsypanov deleted the duplicate branch February 19, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M1
Development

Successfully merging this pull request may close these issues.
3 participants
@stsypanov @jhoeller @spring-projects-issues