Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve type variable recursively in GenericTypeResolver #30079

Merged
merged 1 commit into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
* @author Juergen Hoeller
* @author Sam Brannen
* @author Sebastien Deleuze
* @author Yanming Zhou
* @since 4.2
*/
public class ApplicationListenerMethodAdapter implements GenericApplicationListener {
Expand Down Expand Up @@ -177,13 +178,14 @@ public boolean supportsEventType(ResolvableType eventType) {
return true;
}
if (PayloadApplicationEvent.class.isAssignableFrom(eventType.toClass())) {
if (eventType.hasUnresolvableGenerics()) {
return true;
}
ResolvableType payloadType = eventType.as(PayloadApplicationEvent.class).getGeneric();
if (declaredEventType.isAssignableFrom(payloadType)) {
return true;
}
if (payloadType.resolve() == null) {
// Always accept such event when the type is erased
return true;
}
}
}
return false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
* @author Rob Harrop
* @author Sam Brannen
* @author Phillip Webb
* @author Yanming Zhou
* @since 2.5.2
*/
public final class GenericTypeResolver {
Expand Down Expand Up @@ -167,22 +168,25 @@ public static Type resolveType(Type genericType, @Nullable Class<?> contextClass
else if (genericType instanceof ParameterizedType parameterizedType) {
ResolvableType resolvedType = ResolvableType.forType(genericType);
if (resolvedType.hasUnresolvableGenerics()) {
Class<?>[] generics = new Class<?>[parameterizedType.getActualTypeArguments().length];
ResolvableType[] generics = new ResolvableType[parameterizedType.getActualTypeArguments().length];
Type[] typeArguments = parameterizedType.getActualTypeArguments();
ResolvableType contextType = ResolvableType.forClass(contextClass);
for (int i = 0; i < typeArguments.length; i++) {
Type typeArgument = typeArguments[i];
if (typeArgument instanceof TypeVariable<?> typeVariable) {
ResolvableType resolvedTypeArgument = resolveVariable(typeVariable, contextType);
if (resolvedTypeArgument != ResolvableType.NONE) {
generics[i] = resolvedTypeArgument.resolve();
generics[i] = resolvedTypeArgument;
}
else {
generics[i] = ResolvableType.forType(typeArgument).resolve();
generics[i] = ResolvableType.forType(typeArgument);
}
}
else if (typeArgument instanceof ParameterizedType) {
generics[i] = ResolvableType.forType(resolveType(typeArgument, contextClass));
}
else {
generics[i] = ResolvableType.forType(typeArgument).resolve();
generics[i] = ResolvableType.forType(typeArgument);
}
}
Class<?> rawClass = resolvedType.getRawClass();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
* @author Phillip Webb
* @author Juergen Hoeller
* @author Stephane Nicoll
* @author Yanming Zhou
* @since 4.0
* @see #forField(Field)
* @see #forMethodParameter(Method, int)
Expand Down Expand Up @@ -572,7 +573,7 @@ public boolean hasUnresolvableGenerics() {
private boolean determineUnresolvableGenerics() {
ResolvableType[] generics = getGenerics();
for (ResolvableType generic : generics) {
if (generic.isUnresolvableTypeVariable() || generic.isWildcardWithoutBounds()) {
if (generic.isUnresolvableTypeVariable() || generic.isWildcardWithoutBounds() || generic.hasUnresolvableGenerics()) {
return true;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
* @author Sam Brannen
* @author Sebastien Deleuze
* @author Stephane Nicoll
* @author Yanming Zhou
*/
@SuppressWarnings({"unchecked", "rawtypes"})
class GenericTypeResolverTests {
Expand Down Expand Up @@ -203,6 +204,13 @@ public void resolveMethodParameterWithNestedGenerics() {
assertThat(resolvedType).isEqualTo(reference.getType());
}

@Test
void resolveNestedTypeVariable() throws Exception {
Type resolved = resolveType(ListOfListSupplier.class.getMethod("get").getGenericReturnType(),
StringListOfListSupplier.class);
assertThat(ResolvableType.forType(resolved).getGeneric(0).getGeneric(0).resolve()).isEqualTo(String.class);
}

private static Method method(Class<?> target, String methodName, Class<?>... parameterTypes) {
Method method = findMethod(target, methodName, parameterTypes);
assertThat(method).describedAs(target.getName() + "#" + methodName).isNotNull();
Expand Down Expand Up @@ -402,5 +410,14 @@ public void nestedGenerics(List<Map<String, Integer>> input) {
}
}

public interface ListOfListSupplier<T> {

List<List<T>> get();

}

public interface StringListOfListSupplier extends ListOfListSupplier<String> {

}

}
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
* @author Phillip Webb
* @author Juergen Hoeller
* @author Sebastien Deleuze
* @author Yanming Zhou
*/
@SuppressWarnings("rawtypes")
@ExtendWith(MockitoExtension.class)
Expand Down Expand Up @@ -1314,6 +1315,12 @@ void hasUnresolvableGenericsWhenExtends() throws Exception {
assertThat(type.hasUnresolvableGenerics()).isTrue();
}

@Test
void hasUnresolvableGenericsWhenNested() throws Exception {
ResolvableType type = ResolvableType.forMethodReturnType(ListOfListSupplier.class.getMethod("get"));
assertThat(type.hasUnresolvableGenerics()).isTrue();
}

@Test
void spr11219() throws Exception {
ResolvableType type = ResolvableType.forField(BaseProvider.class.getField("stuff"), BaseProvider.class);
Expand Down Expand Up @@ -1617,6 +1624,12 @@ interface ListOfGenericArray extends List<List<String>[]> {
}


public interface ListOfListSupplier<T> {

List<List<T>> get();

}

static class EnclosedInParameterizedType<T> {

static class InnerRaw {
Expand Down