Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to JUnit 5. #980

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Migrate to JUnit 5. #980

merged 2 commits into from
Apr 15, 2019

Conversation

gregturn
Copy link
Contributor

@gregturn gregturn commented Apr 8, 2019

No description provided.

@gregturn gregturn self-assigned this Apr 8, 2019
@gregturn gregturn added in: infrastructure Build infrastructure and dependency upgrades process: waiting for review labels Apr 8, 2019
@gregturn gregturn added this to the 1.0 M2 milestone Apr 8, 2019
@schauder
#980 - Polishing.
13466eb 
Moved to latest JUnit version.
Limited assertions of exceptions to one method call.
schauder
schauder approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@schauder schauder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a polishing commit.
Other than the changes within that, I think this is fine.

You might consider getting rid of the last references to Hamcrest though.

odrotbohm
odrotbohm requested changes Apr 15, 2019
View reviewed changes
Copy link
Member

@odrotbohm odrotbohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to remove public modifiers as far as possible. I've made good experience with search and replacing public class with class and public void with void and just re-add them there where necessary as the compiler will tell you.

@gregturn gregturn merged commit 13466eb into master Apr 15, 2019
gregturn added a commit that referenced this pull request Apr 15, 2019
@gregturn
#980 - Reduce test visibility.
950a3a7
@gregturn gregturn deleted the junit5 branch April 15, 2019 14:45
@odrotbohm
Copy link
Member

@gregturn – Did you see my comments above? 🤔 I'd like to avoid to do the migration half way.

@gregturn
Copy link
Contributor Author

I reduced visibility of test classes and methods per 950a3a7.

@odrotbohm
Copy link
Member

Nice, I must have missed that. 😱 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odrotbohm odrotbohm odrotbohm requested changes

@schauder schauder schauder approved these changes

Assignees

@gregturn gregturn

Labels
in: infrastructure Build infrastructure and dependency upgrades
Projects
None yet
Milestone
1.0 M2
Development

Successfully merging this pull request may close these issues.
3 participants
@gregturn @odrotbohm @schauder