GH-9492: Fix @SpringIntegration in @Nested test #9506
Conversation
|
@mtomik Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@mtomik Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Thank you for looking into this! The problem is really not so easy to spot.
We ended up with @onobc for the same conclusion as you did.
We will probably ask @sbrannen to improve docs for the @NestedTestCinfiguration to mention that this TestContextAnnotationUtils is important to use in custom annotation processors if we’d like make them working with @Nested as well.
We still would like to see some test suite to cover this functionality and supplement the fix.
You are right, something like AMQP cannot be used in this module, but that still is out of the annotation in the subject responsibility. The listener container you are mentioning in your test is definitely not an AbstractEndpoint we worry here about.
...ava/org/springframework/integration/test/context/SpringIntegrationTestExecutionListener.java
Outdated
Show resolved
Hide resolved
…ntext Switches `MockIntegrationContextCustomizerFactory` to use `TestContextAnnotationUtils` in order to properly support `@NestedTestConfiguration` semantics. Adds an integration test with a base class and several `@Nested` inner test classes to verify the various permutations of `@SpringIntegrationTest` inherit/override behavior when used w/ `@NestedTestConfiguration`.
I agree w/ @artembilan in that It was not easy to spot and you did a great job @mtomik!
I went ahead and contributed this in commit 2. Me and @artembilan paired this afternoon and had the beginnings of the tests so I went ahead and wrapped them up and added to this code proposal. I verified the tests fail as expected w/o the fixes. |
I've created the following issue to address that. |
|
Thanks guys for quick feedback 👍 |
| * to be inherited by concrete subclasses. | ||
| * | ||
| * @author Chris Bono | ||
| * @since 6.4.0 |
There was a problem hiding this comment.
I think we can treat this as a bug, plus this is just a testing feature, so I'm going to back port the fix down to 6.2.x.
Therefore @since 6.2.10 over here.
| * when used with {@link Nested} and {@link NestedTestConfiguration}. | ||
| * | ||
| * @author Chris Bono | ||
| * @since 6.4.0 |
| } | ||
|
|
||
| @Nested | ||
| @NestedTestConfiguration(NestedTestConfiguration.EnclosingConfiguration.INHERIT) |
There was a problem hiding this comment.
I don't think we need this specific test since INHERIT is there by default.
| } | ||
|
|
||
| @Nested | ||
| @NestedTestConfiguration(NestedTestConfiguration.EnclosingConfiguration.INHERIT) |
There was a problem hiding this comment.
This line is redundant since INHERIT is by default.
Hi,
this Pull Request aims to fix issue with using @SpringIntegration test annotation in conjuction with @nested classes
more information can be found here #9492