Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3076: Set batchFailed state in ListenerConsumer even if no commonErrorHandler is configured #3082

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

rroesch1
Copy link
Contributor

This PR is naïve approach to solve #3076 (i am not sure about possible side effects/consequences of this change)

@pivotal-cla
Copy link

@rroesch1 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@rroesch1
Copy link
Contributor Author

@pivotal-cla This is an Obvious Fix

@pivotal-cla
Copy link

@rroesch1 This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good!

Any chances we can have a unit test to cover such a situation?

And from there the fix won't be so obvious, so consider to sign the CLA, please.

@rroesch1
Copy link
Contributor Author

rroesch1 commented Mar 5, 2024

@rroesch1 rroesch1 requested a review from artembilan March 5, 2024 18:28
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add your name to the @author list of the affected classes.

… even if no `commonErrorHandler` is configured

Fixes: spring-projects#3076
@rroesch1
Copy link
Contributor Author

rroesch1 commented Mar 5, 2024

Please, add your name to the @author list of the affected classes.

done

@artembilan artembilan merged commit f4c17c8 into spring-projects:main Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants