GH-3034: IQ API's for remote state stores #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-projects#3034 spring-projects#3034 * Kafka Streams interactive query API's for accessing remote state stores.
artembilan
requested changes
Feb 29, 2024
| }); | ||
| } | ||
|
|
||
| private void primeKafkaStreamsObject() { |
There was a problem hiding this comment.
setupKafkaStreams() or populate?
I don't see a reason in Object suffix at all.
And never saw prime as a verb 😃
There was a problem hiding this comment.
prime can be a verb, but I get your point:)
| * If this property - `application.server` - is not available from the end-user application, then null is returned. | ||
| * @return the current {@link HostInfo} | ||
| */ | ||
| public HostInfo getCurrentKafkaStreamsApplicationHostInfo() { |
| } | ||
|
|
||
| /** | ||
| * Gets the current {@link HostInfo} where this Kafka Streams application is running on. |
There was a problem hiding this comment.
Method Javadocs must be imperative.
Kinda we give a command to do from the first verb.
artembilan
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
LGTM.
But we cannot merge for now since GH is out of order right now: https://www.githubstatus.com/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3034
#3034