Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in setup.cfg: matadata → metadata #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo in setup.cfg: matadata → metadata #418

wants to merge 1 commit into from

Conversation

jdufresne
Copy link
Contributor

@jdufresne jdufresne commented Aug 25, 2021

Fixing to the typo exposed an issue building the wheel when using
setup.py on a system without dateutil installed. To avoid the issue,
move to a fully PEP517 compliant build approach.

@boxed
Copy link
Contributor

boxed commented Aug 25, 2021

The change to read the version is something I disagree with. I've had to hunt down big performance issues on startup for some projects that were partly due to people doing that.

The title of this PR also doesn't reflect the change.

Fixing to the typo exposed an issue building the wheel when using
setup.py on a system without dateutil installed. To avoid the issue,
move to a fully PEP517 compliant build approach.
@jdufresne
Copy link
Contributor Author

The change to read the version is something I disagree with. I've had to hunt down big performance issues on startup for some projects that were partly due to people doing that.

No problem it has been reverted.

It was done originally to handle system without dateutil installed at build time (such as GH actions) but this is now better resolved using a fully PEP517 configuration. Thanks for the nudge in this direction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants