Skip to content

Commit

Permalink
Merge pull request #752 from square/rick/gradle-agp
Browse files Browse the repository at this point in the history
Gradle `8.3` and AGP `7.3.1`
  • Loading branch information
RBusarow authored Sep 28, 2023
2 parents 3bf4bf4 + 98f1f63 commit a2a3ada
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#

[versions]
agp = "7.1.0"
agp = "7.3.1"
autoService = "1.1.1"
autoValue = "1.10.1"
dagger = "2.46.1"
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
13 changes: 10 additions & 3 deletions integration-tests/mpp/android-module/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ android {
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_11
targetCompatibility JavaVersion.VERSION_11
}

lint {
Expand All @@ -37,7 +37,14 @@ android {
}

kotlin {
android()

// The `android()` target is deprecated in Kotlin 1.9.0+,
// but the new `androidTarget()` alternative doesn't exist in KGP 1.8.x.
if (kotlin.coreLibrariesVersion < "1.9.0")
android()
else {
androidTarget()
}

sourceSets {
androidMain {
Expand Down
4 changes: 2 additions & 2 deletions sample/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ android {
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_11
targetCompatibility JavaVersion.VERSION_11
}

lint {
Expand Down
1 change: 0 additions & 1 deletion sample/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

<application
android:name="com.squareup.anvil.sample.App"
android:allowBackup="false"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round"
Expand Down

0 comments on commit a2a3ada

Please sign in to comment.