Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround that disables usePreciseJavaTracking with Kotlin 1.8 support #670

Closed
vRallev opened this issue Dec 31, 2022 · 7 comments · Fixed by #673
Closed

Remove workaround that disables usePreciseJavaTracking with Kotlin 1.8 support #670

vRallev opened this issue Dec 31, 2022 · 7 comments · Fixed by #673
Labels
enhancement New feature or request

Comments

@vRallev
Copy link
Collaborator

vRallev commented Dec 31, 2022 •
edited
Loading

The issue KT-38576 has been resolved with Kotlin 1.8 and the workaround is no longer needed. When Anvil drops support for Kotlin 1.7 it should also remove this workaround.
@vRallev vRallev added the enhancement New feature or request label Dec 31, 2022
@ZacSweers
Copy link
Collaborator

Could it remove the workaround if running in a kotlin 1.8 setup?

@vRallev
Copy link
Collaborator Author

vRallev commented Jan 3, 2023

Absolutely!

vRallev added a commit that referenced this issue Jan 9, 2023
@vRallev
Remove the workaround to disable precise Java tracking. It's not need…
0c4fe8b 
…ed anymore with Kotlin 1.8.

Fixes #670
@vRallev vRallev mentioned this issue Jan 9, 2023
Merged
vRallev added a commit that referenced this issue Jan 9, 2023
@vRallev
Remove the workaround to disable precise Java tracking. It's not need…
4aa5fb9 
…ed anymore with Kotlin 1.8.

Fixes #670
vRallev added a commit that referenced this issue Jan 9, 2023
@vRallev
Remove the workaround to disable precise Java tracking. It's not need…
7b38992 
…ed anymore with Kotlin 1.8.

Fixes #670
vRallev added a commit that referenced this issue Jan 9, 2023
@vRallev
Remove the workaround to disable precise Java tracking. It's not need…
dad6b3a 
…ed anymore with Kotlin 1.8.

Fixes #670
@midery
Copy link

midery commented Jan 13, 2023

Hey! That is a great news!
Anvil has an other workaround that disables incremental kapt stubs generation. Could it also be removed, or is it used to deal with another problem?

@vRallev
Copy link
Collaborator Author

vRallev commented Jan 13, 2023

Yes, that solves a different problem and still is required.

@midery
Copy link

midery commented Jan 26, 2023

Thanks for your reply! I assume that stated problem is described here, but Kotlin issue's status is "Fixed" in 1.8.0.

Disabling incremental compilation for kapt in our codebase makes huge performance drawback on incremental builds, so it'll be really great if you could provide some details.

@vRallev
Copy link
Collaborator Author

vRallev commented Jan 26, 2023

The README got a little out of date. I'm addressing this here: #685 I'm sorry about the confusion.

@midery
Copy link

midery commented Jan 27, 2023

Great! Thanks a lot for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the workaround to disable precise Java tracking. square/anvil
3 participants
@ZacSweers @vRallev @midery