Support explicit API mode for complex map keys #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bddckr
changed the title
ZacSweers
reviewed
Aug 1, 2023
| @@ -12,6 +12,10 @@ if (libs.versions.config.generateDaggerFactoriesWithAnvil.get().toBoolean()) { | |||
|
|
|||
| dependencies { | |||
| kapt libs.dagger2.compiler | |||
|
|
|||
| // Necessary because this is what dagger uses when it runs to support instantiating annotations at runtime | |||
| implementation libs.auto.value.annotations | |||
There was a problem hiding this comment.
I'm curious why this is needed now and not before?
There was a problem hiding this comment.
As seen in that link, when unwrapValue = true, it uses UnwrappedMapKeyGenerator instead, which doesn't use @AutoAnnotation.
Just to clarify:
Without
implementation libs.auto.value.annotations
kapt libs.auto.value.processorwe get
> Task :integration-tests:library:kaptKotlin
C:\Projects\anvil\integration-tests\library\build\tmp\kapt3\stubs\main\com\squareup\anvil\test\WrappedBindingKey.java:6: error: @AutoAnnotation is a necessary dependency if @MapKey(unwrapValue = false). Add a dependency for the annotation, "com.google.auto.value:auto-value-annotations:<current version>", and the annotation processor, "com.google.auto.value:auto-value:<current version>"
public abstract @interface WrappedBindingKey {
^
There was a problem hiding this comment.
Thanks for sharing the extra context 👍
JoelWilcox
approved these changes
Aug 3, 2023
| @@ -178,6 +178,7 @@ internal class MapKeyCreatorGenerator : PrivateCodeGenerator() { | |||
| className, | |||
| properties.entries.map { it.value.callExpression }.joinToCode() | |||
| ) | |||
| .returns(className) | |||
There was a problem hiding this comment.
Nice, coincidentally this is also needed for upgrading to newer KotlinPoet versions
| @@ -12,6 +12,10 @@ if (libs.versions.config.generateDaggerFactoriesWithAnvil.get().toBoolean()) { | |||
|
|
|||
| dependencies { | |||
| kapt libs.dagger2.compiler | |||
|
|
|||
| // Necessary because this is what dagger uses when it runs to support instantiating annotations at runtime | |||
| implementation libs.auto.value.annotations | |||
There was a problem hiding this comment.
Thanks for sharing the extra context 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #735