Better error message for missing intermediates #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldwise001
approved these changes
Apr 6, 2019
|
|
||
| if len(intermediates.Subjects()) == 0 { | ||
| // No intermediates found, maybe broken chain. Let's try AIA fetching? | ||
| intermediate := fetchAIA(certs[0]) |
There was a problem hiding this comment.
We're only trying the first one in the chain? I guess it's pretty rare to have more than 3 certs in a chain.
mcpherrinm
reviewed
Apr 17, 2019
| for _, url := range cert.IssuingCertificateURL { | ||
| resp, err := http.Get(url) | ||
| if err != nil { | ||
| continue |
mcpherrinm
reviewed
Apr 17, 2019
| @@ -109,6 +111,30 @@ func caBundle(caPath string) *x509.CertPool { | |||
| return bundle | |||
| } | |||
|
|
|||
| func fetchAIA(cert *x509.Certificate) *x509.Certificate { | |||
| for _, url := range cert.IssuingCertificateURL { | |||
There was a problem hiding this comment.
rfc4325 says we should look at the file extension to see if it's .cer or .p7c. We could return if it's .p7c and only support .cer fetching
|
should this be merged @mcpherrinm or does it need more work? |
|
I think we should do the p7c/cer and recursive AIA fetching stuff in comments |
mcpherrinm
suggested changes
May 1, 2020
csstaub
requested review from
a team,
mweissbacher,
isemaya-square and
mmontgomery-square
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If verification fails, retries using intermediate retrieved via AIA fetching and updates error message to make it clearer what the misconfiguration is.
Used to print:
But now shows:
This is best-effort.