Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272. The root of the problem is that we're asking the wrong OCSP servers. The current code does something like:
The main problem is that
OCSPServer
is the URI of the OCSP server for that certificate, and by askingissuer.OCSPServer
aboutleaf
, we're requesting OCSP responses from the wrong server. We should be checkingleaf.OCSPServer
in this example instead ofissuer.OCSPServer
.The second problem is that the loop makes no sense. One would not expect any OCSP server in a given chain to be authoritative for a given leaf.
If you do certigo connect google.com, you'll see
The "unauthorized" means the OCSP server we asked doesn't know anything about the cert we asked about.