Implement binary support in JacksonConverterFactory
#3411
Merged
+109
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istvankovacs-priv
changed the title
|
This looks pretty good. Needs some tests though before we can merge to prevent regression. If you can't get to them then I will eventually. |
|
Many thanks for the review! Feel free to implement the tests. |
ctlove0523
approved these changes
Jun 7, 2020
wellmonge
approved these changes
Dec 8, 2020
JakeWharton
force-pushed
the
CBOR-support-in-jackson-converter-factory
branch
4 times, most recently
from
74de86a
to
16541a0
Compare
JakeWharton
force-pushed
the
CBOR-support-in-jackson-converter-factory
branch
from
16541a0
to
48b98a9
Compare
istvankovacs-priv
changed the title
JacksonConverterFactory
istvankovacs-priv
changed the title
JacksonConverterFactoryJacksonConverterFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3403
What?
The
JacksonConverterFactorynow includes binary support.Why?
Previously, the
JacksonResponseBodyConverterrelied on acharStreamto convert the response body content, limiting its capability to handle binary data. This constraint necessitated text-formatted content for serialization, making it challenging to send binary data. Although workarounds existed, it is now possible to easily address this limitation by introducing support for binary data through the use of a customObjectMapper.How?
charStreamtobyteStreamin theJacksonResponseBodyConverter.mediaTypethrough a constructor parameter inJacksonRequestBodyConverter.JacksonConverterFactory, allowing the setting ofmediaTypethrough a nullable second parameter. This new function is called by other overloads to maintain backward compatibility.