Add service class & instance to Invocation #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efemoney
commented
Jun 1, 2022
Comment on lines
62
to
65
| public static Invocation of(Method method, List<?> arguments) { | ||
| Objects.requireNonNull(method, "method == null"); | ||
| Objects.requireNonNull(arguments, "arguments == null"); | ||
| return new Invocation(method, new ArrayList<>(arguments)); // Defensive copy. | ||
| return new Invocation(method.getDeclaringClass(), null, method, new ArrayList<>(arguments)); // Defensive copy. |
There was a problem hiding this comment.
Trying to maintain binary compatibility for anyone using this method by approximating the service class as method.declaringClass and instance as null.
Would love to know if this is good enough or if its okay to break compatibility.
efemoney
commented
Jun 7, 2022
| } | ||
|
|
||
| private final Class<?> service; | ||
| @Nullable private final Object instance; |
There was a problem hiding this comment.
Didn't see another way of maintaining compatibility than making the instance nullable
|
Seems CI wasn't triggered on the last push 🤔 Is there something I can do? |
JakeWharton
force-pushed
the
em/service-instance-in-invocation
branch
from
dba8ebd
to
c216c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3730