Change use_array to bool from string #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
commented
Sep 5, 2023
| @@ -27,7 +27,7 @@ message BuildersOnlyMessage { | |||
| required int32 data = 2; | |||
| repeated int32 message = 3; | |||
| optional NestedMessage nested_message = 4; | |||
| repeated int64 int64 = 5 [packed = true, (wire.use_array) = "true"]; | |||
| repeated int64 int64 = 5 [packed = true, (wire.use_array) = false]; | |||
Base automatically changed from
bquenaudon.2023-07-28.buildersonlykotlin
to
master
September 5, 2023 13:17
oldergod
force-pushed
the
bquenaudon.2023-09-04.fixextension
branch
from
1f8cab4
to
290a9a0
Compare
Egorand
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @JGulbronson
The extension field was a string but it should be a bool.
The generated annotation wasn't receiving the proper adapter so I updated that too.
I noticed that JSON is broken (has not been done) so that needs a fix.