Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext_time_quota_acl: convert to c++ #1847

Closed
wants to merge 65 commits into from
Closed

ext_time_quota_acl: convert to c++ #1847

wants to merge 65 commits into from

Commits on Jun 30, 2024

  1. ext_time_quota_acl: convert logging to c++ 

    Inspired by Coverity CID 1461163,
"Invalid type in argument to printf format specifier"

Rely on c++ ostreams for proper handling of integer types
    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    8398381 View commit details
    Browse the repository at this point in the history

  2. display program name, not file name

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    94fb5a8 View commit details
    Browse the repository at this point in the history

  3. c++-ify KeyString

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    4b11887 View commit details
    Browse the repository at this point in the history

  4. add option to not clear the database at startup

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    fa1caad View commit details
    Browse the repository at this point in the history

  5. refactor clear-if-first, loadTime

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    c116021 View commit details
    Browse the repository at this point in the history

  6. rely less on #defines

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    2d7e4e9 View commit details
    Browse the repository at this point in the history

  7. define -> const int

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    e598395 View commit details
    Browse the repository at this point in the history

  8. source maintenance

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    b8042f9 View commit details
    Browse the repository at this point in the history

  9. refactor constant names, count db entries on startup, use streams ins… 

    …tead of printf
    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    7eb1add View commit details
    Browse the repository at this point in the history

  10. no need for unistd

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    66c7b7c View commit details
    Browse the repository at this point in the history

  11. clarify comment

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    c5c9699 View commit details
    Browse the repository at this point in the history

  12. Fix inverted clearDb flag

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    7e3c6e6 View commit details
    Browse the repository at this point in the history

  13. do not include iostream

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    a248f42 View commit details
    Browse the repository at this point in the history

  14. use size_t

    @kinkie
    kinkie committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    fa7e4ac View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. move from std::string to SBuf

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f6eabe3 View commit details
    Browse the repository at this point in the history

  2. no need to specify dependencies explicitly

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    9161c0d View commit details
    Browse the repository at this point in the history

  3. Source maintenance

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    41fca88 View commit details
    Browse the repository at this point in the history

  4. use auto 

    Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
    @kinkie @rousskov
    kinkie and rousskov committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ceae1d4 View commit details
    Browse the repository at this point in the history

  5. use HLP_MSG 

    Co-authored-by: Amos Jeffries <yadij@users.noreply.github.com>
    @kinkie @yadij
    kinkie and yadij committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    fe59146 View commit details
    Browse the repository at this point in the history

  6. do not log messages to squid

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d17e976 View commit details
    Browse the repository at this point in the history

  7. use debugs() for output

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    bdfe687 View commit details
    Browse the repository at this point in the history

  8. update manual

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d7aed3b View commit details
    Browse the repository at this point in the history

  9. disable debugging level selection

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0a2a1e1 View commit details
    Browse the repository at this point in the history

  10. remove no-clear-db option

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2e55189 View commit details
    Browse the repository at this point in the history

  11. Fix manual

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    af88dd7 View commit details
    Browse the repository at this point in the history

  12. Fix manual

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f7375d7 View commit details
    Browse the repository at this point in the history

  13. Source maintenance

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    733da8d View commit details
    Browse the repository at this point in the history

  14. Fix manual formatting

    @kinkie
    kinkie committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    111dff9 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Clarify comment in src/Makefile.am 

    Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
    @kinkie @rousskov
    kinkie and rousskov committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    354f70c View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. TQ_BUFFERSIZE is static

    @kinkie
    kinkie committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    d60e6b8 View commit details
    Browse the repository at this point in the history

  2. Attempt to restore -l logfile 

    Results in
2024/07/20 23:49:50 ext_time_quota_acl| FATAL: assertion failed: /Users/kinkie/src/squid/coverity/src/comm/minimal.cc:32: "false"

More work is needed
    @kinkie
    kinkie committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    3abbf32 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Enable logging to file

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    e2a7bdb View commit details
    Browse the repository at this point in the history

  2. rename DEBUG_SECTION

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    9154fb1 View commit details
    Browse the repository at this point in the history

  3. Remove useless header

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    7a80caf View commit details
    Browse the repository at this point in the history

  4. Remove useless header

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    2f9404a View commit details
    Browse the repository at this point in the history

  5. reorder debug constant

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    44ba10b View commit details
    Browse the repository at this point in the history

  6. Revert changes to man page

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    08c842a View commit details
    Browse the repository at this point in the history

  7. do not use variable for dbopts

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    51911b4 View commit details
    Browse the repository at this point in the history

  8. Use ToSBuf

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    d40eb9d View commit details
    Browse the repository at this point in the history

  9. no need to null-terminate TDB_DATA

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    0e22830 View commit details
    Browse the repository at this point in the history

  10. Fix debug, restore help text

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    6f17335 View commit details
    Browse the repository at this point in the history

  11. Source format

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    0b02366 View commit details
    Browse the repository at this point in the history

  12. use const TDB_DATA

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    243601a View commit details
    Browse the repository at this point in the history

  13. convert output to stderr to debugs

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    f7cbf32 View commit details
    Browse the repository at this point in the history

  14. Use ToSBuf instead of SBufStream 

    Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
    @kinkie @rousskov
    kinkie and rousskov committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    5850a98 View commit details
    Browse the repository at this point in the history

  15. Use ToSBuf

    @kinkie
    kinkie committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    a57a3ec View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. clarify debug message

    @kinkie
    kinkie committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    946a4f0 View commit details
    Browse the repository at this point in the history

  2. Mark errors as such in log

    @kinkie
    kinkie committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    592e959 View commit details
    Browse the repository at this point in the history

  3. source maintenance

    @kinkie
    kinkie committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f756548 View commit details
    Browse the repository at this point in the history

  4. fix typo in constant

    @kinkie
    kinkie committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    5ecc131 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. move argument parsing back where it was

    @kinkie
    kinkie committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1552a68 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Add ChangeLog entry

    @kinkie
    kinkie committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0b06269 View commit details
    Browse the repository at this point in the history

  2. Revert "Add ChangeLog entry" 

    This reverts commit 0b06269.
    @kinkie
    kinkie committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    8d0a12d View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Merge remote-tracking branch 'upstream/master' into coverity-cid-1461163

    @kinkie
    kinkie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    60223cd View commit details
    Browse the repository at this point in the history

  2. sbuf/Stream.h includes sbuf/SBuf.h 

    Co-authored-by: Amos Jeffries <yadij@users.noreply.github.com>
    @kinkie @yadij
    kinkie and yadij committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    024a8c2 View commit details
    Browse the repository at this point in the history

  3. format polishj 

    Co-authored-by: Amos Jeffries <yadij@users.noreply.github.com>
    @kinkie @yadij
    kinkie and yadij committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    78d2448 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Revert changes to debug

    @kinkie
    kinkie committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9bb3ed0 View commit details
    Browse the repository at this point in the history

  2. reorder LDADD 

    Co-authored-by: Amos Jeffries <yadij@users.noreply.github.com>
    @kinkie @yadij
    kinkie and yadij committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    aba454d View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Revert "reorder LDADD" 

    This reverts commit aba454d.
    @kinkie
    kinkie committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    08cd067 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. Change debug section

    @kinkie
    kinkie committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    7a032a2 View commit details
    Browse the repository at this point in the history

  2. Do not use variable for debug

    @kinkie
    kinkie committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    d1bfd78 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Change debug section

    @kinkie
    kinkie committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f2fb1f5 View commit details
    Browse the repository at this point in the history

  2. change error message on key size mismatch

    @kinkie
    kinkie committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    6a6f126 View commit details
    Browse the repository at this point in the history

  3. fixup: Classify a level-1 error as such 

    Also added a trailing `<<` to ease source code
comprehension, search, and adaptation.
    @rousskov
    rousskov committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f2e131a View commit details
    Browse the repository at this point in the history

  4. Source maintenance

    @kinkie
    kinkie committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f86004d View commit details
    Browse the repository at this point in the history