Fix performance regressions with fastCheck() result copying #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected by Coverity Scan CID 1616162: Performance inefficiencies (AUTO_CAUSES_COPY)
Using the 'auto' keyword without an '&' causes the copy of an object of type Acl::Answer.
kinkie
approved these changes
Aug 12, 2024
yadij
added
M-cleared-for-merge
rousskov
changed the title
rousskov
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
I adjusted PR title to be more precise about the scope of these changes and adjusted PR description to better match similar commit messages. Please check/adjust and re-clear for merging.
FWIW, I am worried that storing a reference to an internal Checklist data member will eventually lead to a dangling reference in one of these or future similar contexts, but since checklist object reuse is rare, and reuse while holding the previous answer may never happen, I am not going to block this PR on these "safety" grounds.
rousskov
added
S-waiting-for-author
squid-anubis
pushed a commit
that referenced
this pull request
Aug 12, 2024
Detected by Coverity. CID 1616162: Performance inefficiencies (AUTO_CAUSES_COPY). Using the 'auto' keyword without an '&' causes the copy of an object of type Acl::Answer.
squid-anubis
added
M-waiting-staging-checks
yadij
added
M-cleared-for-merge
squid-anubis
added
M-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected by Coverity. CID 1616162: Performance inefficiencies
(AUTO_CAUSES_COPY). Using the 'auto' keyword without an '&' causes the
copy of an object of type Acl::Answer.