Maintenance: Clarify unusual IP:Intercept::LookupNat() API #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---- Cherry-picked SQUID-1005-SO_ORIGINAL_DST-loop-bag63 commit fe29ad05.
rousskov
commented
Aug 22, 2024
There was a problem hiding this comment.
This documentation update was implemented during early development stages that eventually led to #1893. The now-documented details of this API explain, for example, why LookupNat() components (adjusted in that draft PR) must not throw on intermittent or "benign" errors. However, this API documentation update is independent from that draft PR.
rousskov
added
M-cleared-for-merge
kinkie
approved these changes
Aug 22, 2024
squid-anubis
pushed a commit
that referenced
this pull request
Aug 24, 2024
squid-anubis
added
the
M-waiting-staging-checks
rousskov
removed
the
S-could-use-an-approval
squid-anubis
added
M-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.