Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev environment: Add npm run fix to fix (some) esLint errors #7337

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Jul 8, 2024

This is the most helpful command I have figured out so far.

Let me know if there is a better way to fix formatting errors, e.g. an auto-formatting tool you use. Currently, I do "Format Document" in VS Code that results in a different style of formatting (semicolons everywhere), and then I run npm run fix to change it to this project's style.

(In case you are curious, I'm trying to refactor the version selector code slightly so that we can have some unit tests, and thus more confidence when improving the "stay on the same page when switching versions" behavior. There is a draft in #7338 )

@ilyagr ilyagr marked this pull request as ready for review July 8, 2024 02:05
@ilyagr ilyagr marked this pull request as draft July 8, 2024 02:06
This is the most helpful command I have figured out so far.

Let me know if there is a better way to fix formatting errors, e.g. an
auto-formatting tool you use.
@ilyagr ilyagr marked this pull request as ready for review July 8, 2024 02:08
@squidfunk
Copy link
Owner

Thanks for the PR! I guess, why not. I'm actually using the VS Code integration by now that automatically fixes on save.

@squidfunk squidfunk merged commit be7ab8a into squidfunk:master Jul 8, 2024
4 checks passed
@ilyagr ilyagr deleted the eslint branch July 8, 2024 16:22
@ilyagr
Copy link
Contributor Author

ilyagr commented Jul 9, 2024

Thanks! It's much easier for me to use this than to figure out how to have VS Code configured differently for different projects.

@squidfunk
Copy link
Owner

You're welcome. However, as mentioned in another comment, please always first discuss fundamental changes with us. You're introducing a lot of very opinionated changes and we're not planning to merge all of those. After all, we need to make sure that we can still guarantee to maintain the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants