Merge branch 'feature/generic-executablefile-skip-tests-on-windows' of …

…https://github.com/jrfnl/PHP_CodeSniffer
squizlabs · Jan 5, 2020 · 65e88a3 · 65e88a3
2 parents 1918934 + 9df8ae1
commit 65e88a3
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/Standards/Generic/Tests/Files/ExecutableFileUnitTest.php b/src/Standards/Generic/Tests/Files/ExecutableFileUnitTest.php
@@ -24,7 +24,8 @@ protected function shouldSkipTest()
     {
         // PEAR doesn't preserve the executable flag, so skip
         // tests when running in a PEAR install.
-        return $GLOBALS['PHP_CODESNIFFER_PEAR'];
+        // Also skip on Windows which doesn't have the concept of executable files.
+        return ($GLOBALS['PHP_CODESNIFFER_PEAR'] || (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN'));
 
     }//end shouldSkipTest()