Skip to content

Commit

Permalink
GH Actions: minor matrix simplification
Browse files Browse the repository at this point in the history
We can remove the `experimental` key in favour of checking against the PHP version in `continue-on-error`.
  • Loading branch information
jrfnl committed Sep 5, 2021
1 parent b10c327 commit 94abd09
Showing 1 changed file with 2 additions and 11 deletions.
13 changes: 2 additions & 11 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,29 +20,20 @@ jobs:
# Keys:
# - custom_ini: Whether to run with specific custom ini settings to hit very specific
# code conditions.
# - experimental: Whether the build is "allowed to fail".
matrix:
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0']
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1']
custom_ini: [false]
experimental: [false]

include:
# Builds running the basic tests with different PHP ini settings.
- php: '5.5'
custom_ini: true
experimental: false
- php: '7.0'
custom_ini: true
experimental: false

# Nightly.
- php: '8.1'
custom_ini: false
experimental: true

name: "PHP: ${{ matrix.php }} ${{ matrix.custom_ini && ' with custom ini settings' || '' }}"

continue-on-error: ${{ matrix.experimental }}
continue-on-error: ${{ matrix.php == '8.1' }}

steps:
- name: Checkout code
Expand Down

0 comments on commit 94abd09

Please sign in to comment.