Generic/DuplicateClassName: fix property visibility #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on the list of public properties which can be changed from rulesets, I came across this property for which it seemed unlikely that these were intended to be public. This is a complex property which expects a multi-level array to be set based on the classes found by the sniff.
|
FYI: build failure is an issue with travis & should be fixed by restarting the build. It's not an issue with the PR. |
|
Yep, I'm pretty sure that's just a mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the list of public properties which can be changed from rulesets (#1278), I came across this property for which it seemed unlikely that it was intended to be public.
This is a complex property which expects a multi-level array to be set based on the classes found by the sniff.