PSR2.Namespace.NamespaceDeclaration false positive on namespace operator #3184
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `namespace` keyword was used as an operator, the sniff would incorrectly throw an error too. Fixed now. Includes unit test.
jrfnl
added a commit
to Yoast/wp-test-utils
that referenced
this pull request
Dec 9, 2020
One of the PSR2 sniffs used contains a bug. The bug has been reported upstream in squizlabs/PHP_CodeSniffer#3184 including a fix. This temporary exclusion should be removed once the upstream PR has been merged and included in a tagged release.
gsherwood
changed the title
|
Thanks for fixing this |
jrfnl
deleted the
feature/psr2-namespacedeclaration-fix-false-positive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
namespacekeyword was used as an operator, the sniff would incorrectly throw an error too.Fixed now.
Includes unit test.