Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments - Tokenizer left-trims '#' to handle shell-style comments #3325

Closed
wants to merge 1 commit into from
Closed

Comments - Tokenizer left-trims '#' to handle shell-style comments #3325

wants to merge 1 commit into from

Conversation

dsavina
Copy link

@dsavina dsavina commented Apr 27, 2021

This proposition aims to make possible the use of shell-style comments as Code Sniffer directives, for instance:

  #phpcs:disable Never.Say.Never
  echo "Never say never";
  #phpcs:enable

Signed-off-by: Dorian Savina <d.savina@thecodingmachine.com>
@jrfnl
Copy link
Contributor

jrfnl commented Apr 27, 2021

Duplicate of #3071 ?

@gsherwood
Copy link
Member

Thanks for the PR, but I'll close as a duplicate given the other PR is identical. I'll post a comment over there to get it moving again.

@gsherwood gsherwood closed this Apr 27, 2021
@dsavina
Copy link
Author

dsavina commented Apr 28, 2021

My bad, I hadn't seen the other PR; thanks for your responsiveness, though!

@dsavina dsavina deleted the fix/shell-style-comment branch April 28, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants