Squiz/ObjectInstantiation: bug fix - account for null coalesce #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Squiz.Objects.ObjectInstantiation` did not take null coalesce into account. It also was potentially a little too lenient for ternaries as an inline then or inline else token before the `new` keyword would be considered an assignment, while it was never checked that the result of the ternary was actually assigned to something. While still not 100%, this commit improves the sniffs to: 1. Allow for null coalesce assignments `??=`. 2. For ternary tokens + null coalesce `??`: verify if the result of either of these is actually "assigned" to something (or preceded by one of the other "allowed" tokens). This should reduce the number of both false positives as well as false negatives, though there is still the potential for some false negatives - see the test on line 32 of the test case file. This could be further reduced in a future iteration on this sniff, but for now, this fix can be considered a significant step forward. Includes unit tests. Fixes 3333
|
Thanks for fixing this. Line 32 probably is a false negative, although it is an interesting one and could go either way. |
jrfnl
deleted the
feature/3333-squiz-objectinstantiation-bugfix-allow-for-null-coalesce
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Squiz.Objects.ObjectInstantiationdid not take null coalesce into account.It also was potentially a little too lenient for ternaries as an inline then or inline else token before the
newkeyword would be considered an assignment, while it was never checked that the result of the ternary was actually assigned to something.While still not 100%, this commit improves the sniffs to:
??=.??: verify if the result of either of these is actually "assigned" to something (or preceded by one of the other "allowed" tokens).This should reduce the number of both false positives as well as false negatives, though there is still the potential for some false negatives - see the test on line 32 of the test case file.
This could be further reduced in a future iteration on this sniff, but for now, this fix can be considered a significant step forward.
Includes unit tests.
Fixes #3333