Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 | Squiz/BlockComment: prevent false positives with attributes #3398

Merged
merged 1 commit into from
Jul 29, 2021
Merged

PHP 8.0 | Squiz/BlockComment: prevent false positives with attributes #3398

merged 1 commit into from
Jul 29, 2021

Commits on Jul 23, 2021

  1. Squiz/BlockComment: prevent false positives with attributes 

    PHP 8.0+ attributes can be placed between a docblock and the function/class declaration it applies to.

The `Squiz.Commenting.BlockComment` sniff did not yet take this into account when determining whether a comment was a docblock or an block comment incorrectly using the docblock syntax.

This would result in false positive `Block comments must be started with /*` errors.

Fixed now.
    @jrfnl
    jrfnl committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    39dd4b7 View commit details
    Browse the repository at this point in the history