Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build dependencies #19

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

srmainwaring
Copy link
Owner

This PR updates the build dependencies to use the main branch of pybind11_protobuf following:

Details

  • Move global dependency settings to top level CMakeLists.txt.
  • Remove options to build dependencies.
  • Add option to build tests (placeholder).
  • Only FetchContent if find_package fails.
  • Update tag for dependency pybind11_protobuf to main.

- Move global dependency settings to top level CMakeLists.txt.
- Remove options to build dependencies.
- Add option to build tests (placeholder).
- Only FetchContent if find_package fails.
- Update tag for dependency pybind11_protobuf.

Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
@srmainwaring srmainwaring self-assigned this Mar 9, 2023
@srmainwaring srmainwaring added the enhancement New feature or request label Mar 9, 2023
@srmainwaring srmainwaring merged commit 67eed26 into main Mar 9, 2023
@srmainwaring srmainwaring deleted the srmainwaring/pr-cmake-deps branch April 26, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant