Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added delay option for the review buttons #1049

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

4Source
Copy link
Contributor

@4Source 4Source commented Aug 12, 2024

Added the option to enable a delay for the review buttons like I mentioned in #996 would be great if someone could provide feedback and/or could test it.

src/lang/locale/ar.ts Outdated Show resolved Hide resolved
src/lang/locale/cz.ts Outdated Show resolved Hide resolved
src/lang/locale/en.ts Outdated Show resolved Hide resolved
src/settings.ts Outdated Show resolved Hide resolved
@st3v3nmw st3v3nmw changed the title [FEAT] Added delay option for the review buttons feat: added delay option for the review buttons Aug 18, 2024
@4Source 4Source requested a review from st3v3nmw August 18, 2024 10:49
Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Please have a look at the merge conflict.. I can't resolve it on the UI.

# Conflicts:
#	src/gui/flashcard-review-view.tsx
Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I think the rebase / merge messed something up. I can't see the code that actually does the delay.. It was there before.

@4Source
Copy link
Contributor Author

4Source commented Sep 24, 2024

Agree this must be lost during the renaming

@st3v3nmw
Copy link
Owner

Agree this must be lost during the renaming

Thanks.

@st3v3nmw st3v3nmw merged commit d28ae44 into st3v3nmw:master Sep 25, 2024
2 checks passed
@4Source 4Source deleted the feat_996 branch September 25, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants