Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tiles extension #245

Closed
lossyrob opened this issue Aug 27, 2021 · 1 comment
Closed

Remove tiles extension #245

lossyrob opened this issue Aug 27, 2021 · 1 comment
Assignees
@moradology

Comments

@lossyrob
Copy link
Member

There is currently a tiles extension which allows adding titiler routes to stac-fastapi. My understanding was that this was added as a sort of demo, and that in practice you wouldn't want to couple your STAC API with the titiler implementation - it's better to have those run as separate services, and tiler serving is beyond the scope of this project. Titiler also can cause depenency conflict - e.g. it has a pinned version of fastapi, which overrides a pinned version declared by a stac-fastapi subpackage if that stac-fastapi.extensions extra is installed.

Based on the conversations I've had with stac-fastapi users that I know of, this shouldn't be a problem; however I'm not sure if someone out there is using this and would hate to see it go. Does anyone depend on this extension? If not, I'll make a PR to drop it.
lossyrob added a commit that referenced this issue Aug 27, 2021
@lossyrob
Remove tiler tests.
eef06d5 
This breaks the dockerized tests as titiler isn't installed in the
docker image anymore. Based on the outcome of #245, these (and ideally
more robust tests) can be re-added, or the tiles extension will be
dropped completely.
@lossyrob lossyrob mentioned this issue Aug 27, 2021
Merged
4 tasks
lossyrob added a commit that referenced this issue Aug 27, 2021
@lossyrob
Pin FastAPI to avoid OpenAPI docs rendering issues (#246)
a68d280 
* Reorder install order in docker build; remove tiles from extension

titiler depends on an earlier version of FastAPI and doesn't allow the
dockerized server to have the FastAPI version dictated by the
stac-fastapi setup.

* Pin fastapi in stac_fastapi.types; remove from other packages.

This pins fastapi to 0.67.* in stac_fastapi.types, and has all other
packages rely on that dependency to pull in the correct version. This
also adds a missing dependency on stac_fastapi.types in
stac_fastapi.api.

Fixes #242

* Remove tiler tests.

This breaks the dockerized tests as titiler isn't installed in the
docker image anymore. Based on the outcome of #245, these (and ideally
more robust tests) can be re-added, or the tiles extension will be
dropped completely.

* Add changelog entry

* Install types first in CI, as it's the base subpackage

* Remove stac_fastapi.extensions[tiles] from test install.

I do not know why, but installing the tiles extra re-installs
stac-fastapi.types in a way that breaks an import.
@geospatial-jeff
Copy link
Collaborator

My understanding was that this was added as a sort of demo

This is correct, I added it as a demo for the cloud native geo sprint last fall, agreed it shouldn't be here. Something like https://github.com/developmentseed/eoAPI is a better pattern.

@moradology moradology self-assigned this Dec 14, 2021
@moradology moradology mentioned this issue Dec 14, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moradology moradology

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@moradology @lossyrob @geospatial-jeff