Set collection_id on search for pgstac get_item; update to pgstac 0.3.4 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen strange behavior described in stac-utils/pgstac#58, where searching only by an Item ID was returning the incorrect Item. Specifyng the Collection ID, which this method should be doing, solved this in my case.
|
Nice to get this in before cutting the next release. Everything seems to be doing what it's supposed to, so 👍 |
moradology
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change modifies the behavior of get_item in the pgstac backend to set the collection ID. This is correct behavior - item Ids must be unique within a collection, and a collection_id is supplied in the call. Also, as mentioned in stac-utils/pgstac#58, pgstac can return incorrect results if queried with just an Item ID without the Collection ID set.
This PR also updates to pgstac 0.3.4, and fixes the NotFoundError message in get_item.
PR Checklist:
pre-commit run --all-files)make test)make docs)