make stats and histogram optional #466 #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
reviewed
Oct 2, 2023
gadomski
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Thanks for the PR and the extensive tests 👍🏼. For your awareness, it can be slightly nicer to open the PR from a feature branch on your fork (e.g. optional-stats-and-hist) instead of PR-ing directly from main. Not a huge issues for something like this, but generally can be better practice since you might need to uptake new changes to upstream main at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit a pull request, please fill in the following:
Related Issue(s):
#466
Description:
add kwargs
statisticsandhistogramtocore.add_raster_to_item.add tests
PR checklist:
scripts/format).scripts/lint).scripts/test).