Remove get_convo asserts from tests #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to port all tests currently using DummyLM to a new DummyLM which inherits from dspy.LM - hence migrating the test suite to use the new ChatAdapter.
It also replicates all current tests which use the renamed DspDummyLM(dsp.LM) into a folder tests/DSP_LM, to be deleted when 2.6 is released and dsp.LM is deprecated.
The tests for the to-be-deprectaed MIPRO have not been migrated to use dspy.LM.
I also included a fix for predictors which return Literal types (or any type the origin of which does not have a name attribute) with a small tweak to dspy/adapters/chat_adapter.py:get_annotation_name. Without this change tests/functional/test_functional.py:test_literal.* fail. Can also skip those tests and create another PR.
This PR also adds an auto-used fixture which resets the dspy.settings to default after each test without which some tests were interdependent.
Remove from the test suite any examination of the lm's history - makes the tests easier to port to additional adapters.