Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minor version 1.1.0 #98

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Bump minor version 1.1.0 #98

merged 4 commits into from
Mar 5, 2024

Conversation

aecorn
Copy link
Collaborator

@aecorn aecorn commented Feb 29, 2024 •
edited
Loading

This PR is set to bump the "major rewrite" for the new Pypi-template onto a new version on Pypi.
This includes bumoing the version to 1.1.0

  • Dependabot merges triggered sonarcloud analysis, so I was able to refactor some complexity smells.
  • Some additions to the Readme.
  • A lot of the Progress on the re-write is already pushed to main (to close security warnings), see Major rewrite -> new pypi template #95 , but not pushed to Pypi yet.

@aecorn aecorn marked this pull request as ready for review February 29, 2024 08:13
@aecorn aecorn marked this pull request as draft March 4, 2024 07:56
@aecorn aecorn changed the title changing logger slightly, add logger section to readme Bump minor version 1.1.0 - wait for "trusted publisher" Mar 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@aecorn aecorn marked this pull request as ready for review March 5, 2024 09:17
@aecorn aecorn requested a review from mallport March 5, 2024 09:17
@aecorn aecorn changed the title Bump minor version 1.1.0 - wait for "trusted publisher" Bump minor version 1.1.0 Mar 5, 2024
mallport
mallport approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@mallport mallport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@aecorn aecorn merged commit 2127b15 into main Mar 5, 2024
12 checks passed
@aecorn aecorn deleted the pypi_template_established branch March 5, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mallport mallport mallport approved these changes

@bjornandre bjornandre Awaiting requested review from bjornandre

@arneso-ssb arneso-ssb Awaiting requested review from arneso-ssb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aecorn @mallport