Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correct header rank and keyboard naviagtion #397

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

tilen1976
Copy link
Contributor

@tilen1976 tilen1976 commented Aug 19, 2024

This offers a solutions for faults fault in header ranks and not possible to navigate Tabs with keyboard. Both important for accessibility and machine reading:

  • A title for each workspace with correct header in order to place the workspace in the correct rank order (open for suggestions for title content)
  • A solution to make dash core component Tabs accessible for keyboard navigation:
    • Use 'Keyboard' from 'dash extensions'
    • wrap tabs in focusable div with tabindex
    • add callback to handle keyboard navigation for Tabs

Screenshot 2024-08-19 at 12 19 50

Screenshot 2024-08-19 at 12 08 18

@tilen1976 tilen1976 requested a review from a team as a code owner August 19, 2024 12:37
Copy link
Contributor

@Jorgen-5 Jorgen-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tilen1976 tilen1976 merged commit a0cea9d into master Aug 19, 2024
16 checks passed
@tilen1976 tilen1976 deleted the chore/fix-header-rank branch August 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants