Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique id to tabs so aria-controls in tab component points to cor… #2113

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

omsaggau
Copy link
Contributor

…rect tab

@omsaggau
Copy link
Contributor Author

Together with statisticsnorway/ssb-component-library#866

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@johnnadeluy johnnadeluy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ⭐️

@omsaggau omsaggau merged commit 8ed7f8f into master Sep 28, 2023
7 of 8 checks passed
@omsaggau omsaggau deleted the MIMIR-1870_tabs-unique-id branch September 28, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants