Skip to content

Commit

Permalink
Storybook upgrade (#992)
Browse files Browse the repository at this point in the history
* Upgrading minor and patch versions

* Upgrading major css-loader, sass-loader, stylelint

* Upgrade storybook to version 8

* Remove deprecated addons package, unnecessary unused story

* Remove deprecated CSS lint rules.

Should probably use Prettier in this project instead.
  • Loading branch information
Glenruben authored Apr 8, 2024
1 parent d0cb949 commit dffdb1d
Show file tree
Hide file tree
Showing 5 changed files with 5,019 additions and 5,458 deletions.
86 changes: 41 additions & 45 deletions .storybook/main.js
Original file line number Diff line number Diff line change
@@ -1,53 +1,49 @@
const path = require('path');

module.exports = {
stories: ['../**/*.story.jsx'],
addons: [
'@storybook/addon-links'
],
staticDirs: ['../src/media'],
stories: ['../**/*.story.jsx'],

webpackFinal: config => {
const fileLoaderRule = config.module.rules.find(
(rule) => rule.test && rule.test.test(".svg")
);
fileLoaderRule.exclude = /\.svg$/;
config.module.rules.push(
{
include: path.resolve(__dirname, '../'),
test: /\.(s*)css$/i,
sideEffects: true,
use: [
'style-loader',
'css-loader',
'sass-loader'
],
},
{
test: /\.(png|jpg|gif|woff|ttf)$/,
use: [
'file-loader',
],
},
{
test: /\.svg$/,
use: ['@svgr/webpack'],
},
);
return config;
},
addons: [
'@storybook/addon-links',
'@storybook/addon-webpack5-compiler-babel',
],

resolve: {
extensions: ['.jsx', '.js'],
},
staticDirs: ['../src/media'],

features: {
postcss: false,
},
webpackFinal: (config) => {
const fileLoaderRule = config.module.rules.find(
(rule) => rule.test && rule.test.test('.svg')
);
fileLoaderRule.exclude = /\.svg$/;
config.module.rules.push(
{
include: path.resolve(__dirname, '../'),
test: /\.(s*)css$/i,
sideEffects: true,
use: ['style-loader', 'css-loader', 'sass-loader'],
},
{
test: /\.(png|jpg|gif|woff|ttf)$/,
use: ['file-loader'],
},
{
test: /\.svg$/,
use: ['@svgr/webpack'],
}
);
return config;
},

framework: {
name: '@storybook/react-webpack5',
options: {}
},
};
resolve: {
extensions: ['.jsx', '.js'],
},

features: {
postcss: false,
},

framework: {
name: '@storybook/react-webpack5',
options: {},
},
};
16 changes: 0 additions & 16 deletions .stylelintrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,11 @@
"color-no-hex": true,
"comment-no-empty": true,
"declaration-block-no-duplicate-properties": true,
"declaration-block-semicolon-newline-after": "always-multi-line",
"declaration-colon-space-after": "always",
"declaration-colon-space-before": "never",
"declaration-empty-line-before": "never",
"length-zero-no-unit": true,
"no-extra-semicolons": true,
"max-empty-lines": 1,
"no-descending-specificity": null,
"number-leading-zero": "never",
"number-no-trailing-zeros": true,
"property-case": "lower",
"rule-empty-line-before": "always-multi-line",
"selector-combinator-space-after": "always",
"selector-combinator-space-before": "always",
"selector-list-comma-newline-after": "never-multi-line",
"selector-list-comma-space-after": "always",
"selector-list-comma-space-before": "never",
"selector-pseudo-class-case": "lower",
"selector-pseudo-element-case": "lower",
"selector-type-case": "lower",
"selector-type-no-unknown": [true, {"ignore": ["default-namespace"]}],
"value-list-comma-newline-after": "never-multi-line"
}
}
Loading

0 comments on commit dffdb1d

Please sign in to comment.