Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Component: Part 1 #1100

Merged
merged 40 commits into from
Jun 12, 2024
Merged

Table Component: Part 1 #1100

merged 40 commits into from
Jun 12, 2024

Conversation

johnnadeluy
Copy link
Contributor

@johnnadeluy johnnadeluy commented Jun 6, 2024 •
edited
Loading

  • Adds support for typescript
  • Adds husky for pre-commit linting and test checks
  • New Table component

MIM-1890

@johnnadeluy
Add Table component; WIP
7810ce0 
MIM-1890
@johnnadeluy
Styling adjustments
c94b6a5
@johnnadeluy
.
fb23cc8
@johnnadeluy
Fix storybook example width and documentation
af99c0d
@johnnadeluy
Update examples and styling; indentation, text-alignment etc
1654fec
@johnnadeluy
Add support for react typescript
e537037 
Add scroll functionality to Table component (wip)
@johnnadeluy
Add basic table components and update examples accordingly
a4ad1fb
@johnnadeluy
Add statistics table styling for text-alignment
259907f
@johnnadeluy
Update Table component examples
1a28ccd
@johnnadeluy
Add prop types for Table components and minor adjustments
aab08e8
@johnnadeluy
Move all the Table related components to Table component instead
dbd46e2
@johnnadeluy
Add dataNoteRefs props and make adjustments to Table
fa4b8cb
@johnnadeluy
Remove unused prop for story example for Table
ae48a29
@johnnadeluy
Fix typography (font-family, line-height, sup)
5ed0aa8
@johnnadeluy
Update Table component documentation
d73fbad
@johnnadeluy
Remove and comment out scroll functionality and add forwardRef
0c76f4c
@johnnadeluy
Merge branch 'master' of https://github.com/statisticsnorway/ssb-comp…
f5b6473 
…onent-library into MIM-1890_table_component
@johnnadeluy
Include .tsx files in rollup.config.js
8151bb9
@johnnadeluy
Include .ts files in the rollup.config,js fuke
260effb
@johnnadeluy
Install @rollup/plugin-typescript for rollup
7fcdb1c
@johnnadeluy
Remove duplicate code in Table story example
7561080
@johnnadeluy
Add a snapshot match test for Table
8be5b66
@johnnadeluy
Include ts and tsx in moduleFileExtensions for jest
2502002 
Tweak test code to avoid duplicate code
annesiri
annesiri reviewed Jun 6, 2024
View reviewed changes
package.json Show resolved Hide resolved
annesiri
annesiri reviewed Jun 6, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@annesiri
Copy link
Contributor

annesiri commented Jun 6, 2024

Generelt kan det være lurt å søke etter alle steder det refereres til *.jsx/*.js og sjekke om *.tsx/*.ts skal inn på disse stedene

@johnnadeluy johnnadeluy marked this pull request as ready for review June 7, 2024 07:29
annesiri
annesiri reviewed Jun 11, 2024
View reviewed changes
.eslintrc Show resolved Hide resolved
@johnnadeluy johnnadeluy assigned annesiri and unassigned Carl-OW Jun 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
20 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johnnadeluy johnnadeluy merged commit 00f4369 into master Jun 12, 2024
6 checks passed
@johnnadeluy johnnadeluy deleted the MIM-1890_table_component branch August 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpande michaelpande michaelpande left review comments

@annesiri annesiri annesiri approved these changes

Assignees

@annesiri annesiri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnnadeluy @annesiri @michaelpande @Carl-OW