Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part 2: Table Component #1116

Merged
merged 10 commits into from
Jun 14, 2024
Merged

Part 2: Table Component #1116

merged 10 commits into from
Jun 14, 2024

Conversation

johnnadeluy
Copy link
Contributor

@johnnadeluy johnnadeluy commented Jun 14, 2024 •
edited
Loading

  • Setup typescript support for JEST (ts-jest etc)
  • Setup prettier for formatting (A separate PR for formatting will be coming later)
  • Create simple rendering tests for Table component

@johnnadeluy
Setup ts-jest for typescript support for JEST tests
ad6e505 
Create a simple test for Table
@johnnadeluy
Setup prettier with eslint plugin and config (without a fix yet)
29d8c04
@johnnadeluy
Merge branch 'master' of https://github.com/statisticsnorway/ssb-comp…
6338b7a 
…onent-library into MIM-1890_setup_ts-jest_table
@johnnadeluy
Use tilde instead carat for prettier and ts-jest related dev dependen…
7241470 
…cies
@johnnadeluy
Bump @storybook/addon-links, @storybook/react-webpack5 and @babel/pre…
71b77fc 
…set-typescript versions

to the matching versions in master so package-lock is in sync
@johnnadeluy
Resolve @rollup/rollup-linux-x64-gnu build error after merge master t…
58d12ae 
…o branch
@johnnadeluy
Adds more tests to Table component and minor refactor
de64cdd
@johnnadeluy
Update Table test
37541a2
@johnnadeluy
Add id attribute for th Table cell and use scope for examples and tests
54dacce 
Update documentation and fix linting for Table
@johnnadeluy
Minor code refactoring; rename Table tests
55fdaa0
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johnnadeluy johnnadeluy marked this pull request as ready for review June 14, 2024 11:42
@johnnadeluy johnnadeluy changed the title Mim 1890 setup ts jest table Part 2: Table Component Jun 14, 2024
@annesiri annesiri assigned annesiri and unassigned ssb-cgn Jun 14, 2024
annesiri
annesiri approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@annesiri annesiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut 👍

@johnnadeluy johnnadeluy merged commit c0bf8c5 into master Jun 14, 2024
6 checks passed
@johnnadeluy johnnadeluy deleted the MIM-1890_setup_ts-jest_table branch August 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annesiri annesiri annesiri approved these changes

Assignees

@annesiri annesiri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnnadeluy @annesiri @ssb-cgn