Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid message header size #13372

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix: invalid message header size #13372

merged 1 commit into from
Jan 31, 2024

Conversation

igor-sirotin
Copy link
Contributor

Fixes #13279

Description

The bug appeared with this fix: #12957
I kept the fix working and fixed the part not to expand the header if not needed.

Screenshot 2024-01-31 at 18 18 12

And activity center is still ok:

Screenshot 2024-01-31 at 18 17 54 Screenshot 2024-01-31 at 18 18 03

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔝

@status-im-auto
Copy link
Member

status-im-auto commented Jan 31, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9fc5c1f #1 2024-01-31 18:28:29 ~6 min tests/nim 📄log
✔️ 9fc5c1f #1 2024-01-31 18:30:03 ~7 min macos/aarch64 🍎dmg
✔️ 9fc5c1f #1 2024-01-31 18:32:20 ~10 min macos/x86_64 🍎dmg
✔️ 9fc5c1f #1 2024-01-31 18:32:53 ~10 min tests/ui 📄log
✔️ 9fc5c1f #1 2024-01-31 18:38:51 ~16 min linux/x86_64 📦tgz
✔️ 9fc5c1f #1 2024-01-31 18:52:52 ~30 min tests/e2e 📄log
✔️ 9fc5c1f #1 2024-01-31 18:58:12 ~36 min windows/x86_64 💿exe

Copy link
Contributor

@kounkou kounkou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

@igor-sirotin igor-sirotin merged commit c995ff2 into master Jan 31, 2024
8 of 9 checks passed
@igor-sirotin igor-sirotin deleted the fix/issue-13279 branch January 31, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message timestamp in a channel moved to the right
5 participants