fix Sometimes mentions list does not appear after typing @ in chat input filed #15622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrkhalil
approved these changes
Apr 12, 2023
Jenkins BuildsClick to see older builds (63)
|
93% of end-end tests have passedFailed tests (2)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (27)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
ilmotta
approved these changes
Apr 12, 2023
|
@qfrank thanx for the PR. Sometimes am still facing the issue. Although there no clear steps of how to reproduce that. Below I attach video and logs from PR build. mention.mp4 |
|
emm.. just probably found the cause 🤔 |
|
@qfrank |
qfrank
force-pushed
the
fix/15616
branch
2 times, most recently
from
43e39f7
to
2bc7d15
Compare
|
@pavloburykh @churik pls retry the latest build, thank you 🙂 |
79% of end-end tests have passedFailed tests (6)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (23)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
flexsurfer
approved these changes
Apr 17, 2023
|
@yevh-berdnyk tried both Would you mind taking a look? |
|
@qfrank mention.mp4And as in terms ofe2e tests it is getting worse here (in order to tap on an item I need to re-open the list several times) I cannot approve it for merging. Perharps it is worth to wait until new composer is merged and then try this behaviour there. |
+1 @churik |
Also will need check behaviour when mention list does not appear after typing @ while editing message. telegram-cloud-document-2-5346305496842249354.mp4 |
|
update: just rebased with new composer |
40% of end-end tests have passedNot executed tests (4)Failed tests (15)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Passed tests (10)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
sorry... i made a mistake.. i force pushed and ignored commits that @churik made.. cc @pavloburykh |
|
just fixed a small issue, after user selected mention user from mention list, type @ won't popup mention list , it's ready to retest now |
86% of end-end tests have passedNot executed tests (1)Failed tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (25)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
|
@qfrank sorry for a long testing cycle this time! |
churik
approved these changes
Apr 26, 2023
…n chat input filed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15616
status: ready