Improve QR Code Component in Quo Preview Sandbox #15755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
force-pushed
the
add-qr-url-gen-to-image-server
branch
from
7cae42c
to
7282c2c
Compare
Jenkins BuildsClick to see older builds (8)
|
siddarthkay
force-pushed
the
add-qr-url-gen-to-image-server
branch
from
7282c2c
to
93c34c7
Compare
J-Son89
approved these changes
Apr 26, 2023
ilmotta
reviewed
Apr 26, 2023
There was a problem hiding this comment.
We've been trying to add component specs to quo2 components @siddarthkay. Would you mind writing some?
Apart from the missing test, I think the component looks good in my tests. Good stuff Sid!
| (let [state (reagent/atom {:text "https://status.im" | ||
| :error-correction-level :highest}) | ||
| text (reagent/cursor state [:text]) | ||
| error-correction-level (reagent/cursor state [:error-correction-level]) |
There was a problem hiding this comment.
I like the usage of cursors in these preview screens, I'll use your idea here in the future.
ilmotta
approved these changes
Apr 26, 2023
2 tasks
siddarthkay
force-pushed
the
add-qr-url-gen-to-image-server
branch
2 times, most recently
from
ddbe0e0
to
2685561
Compare
This PR adds the ability to : - Generate a QR by passing any url. - See different error correction levels. - Shows the media server url for that specific QR code. - Moved media server URI generation logic to `image_server.cljs`
siddarthkay
force-pushed
the
add-qr-url-gen-to-image-server
branch
from
2685561
to
c1a6e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to :
image_server.cljsThis is how it looks like:
Screen.Recording.2023-04-26.at.3.10.18.PM.mov
status: ready