Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification Centre - add Empty Content screen #16715

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Notification Centre - add Empty Content screen #16715

merged 1 commit into from
Jul 25, 2023

Conversation

mmilad75
Copy link
Contributor

This PR adds the empty placeholder for the Notification Center.

fixes #16334

Android iOS
android.mov
ios.mov

Platforms

  • Android
  • iOS
Functional
  • notification center ui

Steps to test

  • Open app
  • Press Notifications icon

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jul 18, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (24)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 77a8469 #1 2023-07-18 13:26:56 ~6 min android 🤖apk 📲
✔️ 77a8469 #1 2023-07-18 13:27:07 ~6 min android-e2e 🤖apk 📲
✔️ 5a6c108 #2 2023-07-18 13:36:40 ~8 min android-e2e 🤖apk 📲
✔️ 5a6c108 #2 2023-07-18 13:36:49 ~8 min android 🤖apk 📲
✔️ 5a6c108 #2 2023-07-18 13:37:54 ~9 min tests 📄log
✔️ 5a6c108 #2 2023-07-18 13:41:19 ~12 min ios 📱ipa 📲
✔️ b8bb5e4 #3 2023-07-18 16:33:34 ~6 min ios 📱ipa 📲
✔️ b8bb5e4 #3 2023-07-18 16:35:49 ~9 min android-e2e 🤖apk 📲
✔️ b8bb5e4 #3 2023-07-18 16:35:50 ~9 min android 🤖apk 📲
✔️ b8bb5e4 #3 2023-07-18 16:36:20 ~9 min tests 📄log
✔️ 9ebfde7 #5 2023-07-20 13:36:41 ~6 min android-e2e 🤖apk 📲
✔️ 9ebfde7 #5 2023-07-20 13:37:54 ~7 min android 🤖apk 📲
✔️ 9ebfde7 #5 2023-07-20 13:38:02 ~7 min ios 📱ipa 📲
✔️ 9ebfde7 #5 2023-07-20 13:38:23 ~8 min tests 📄log
❌ 45915e1 #6 2023-07-24 19:18:36 ~2 min tests 📄log
❌ 939ccde #7 2023-07-24 19:22:53 ~2 min tests 📄log
✔️ 939ccde #7 2023-07-24 19:26:36 ~6 min android-e2e 🤖apk 📲
✔️ 939ccde #7 2023-07-24 19:26:36 ~6 min android 🤖apk 📲
✔️ 939ccde #7 2023-07-24 19:27:51 ~7 min ios 📱ipa 📲
❌ 35d7a3c #8 2023-07-25 11:13:49 ~2 min tests 📄log
✔️ 35d7a3c #8 2023-07-25 11:18:52 ~7 min ios 📱ipa 📲
✔️ 35d7a3c #8 2023-07-25 11:19:35 ~8 min android 🤖apk 📲
✔️ 35d7a3c #8 2023-07-25 11:19:36 ~8 min android-e2e 🤖apk 📲
❌ a501ed4 #9 2023-07-25 12:02:04 ~3 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 078a1c5 #10 2023-07-25 12:08:12 ~5 min android 🤖apk 📲
✔️ 078a1c5 #10 2023-07-25 12:08:33 ~5 min android-e2e 🤖apk 📲
✔️ 078a1c5 #10 2023-07-25 12:11:15 ~8 min ios 📱ipa 📲
✔️ 078a1c5 #10 2023-07-25 12:12:33 ~9 min tests 📄log
✔️ 4210aa5 #12 2023-07-25 14:02:32 ~5 min android-e2e 🤖apk 📲
✔️ 4210aa5 #12 2023-07-25 14:03:29 ~6 min android 🤖apk 📲
✔️ 4210aa5 #12 2023-07-25 14:03:58 ~6 min ios 📱ipa 📲
✔️ 4210aa5 #12 2023-07-25 14:06:43 ~9 min tests 📄log

ibrkhalil
ibrkhalil approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@ibrkhalil ibrkhalil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
non blocking comments

src/status_im2/contexts/shell/activity_center/view.cljs Outdated Show resolved Hide resolved
ajayesivan
ajayesivan approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 🎉

J-Son89
J-Son89 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @mmilad75! :)

smohamedjavid
smohamedjavid approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@smohamedjavid smohamedjavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! @mmilad75 🚀

translations/en.json Outdated Show resolved Hide resolved
src/status_im2/contexts/shell/activity_center/view.cljs Outdated Show resolved Hide resolved
@status-im-auto
Copy link
Member

61% of end-end tests have passed

Total executed tests: 36
Failed tests: 14
Passed tests: 22

IDs of failed tests: 702782,702733,702784,702732,702813,703133,702851,702745,702783,702855,703202,703391,702731,702730

Failed tests (14)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find `Button` by `accessibility id`: `show-profiles`
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:433: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact(s) was (were) not restored from backup: MyCustomNickname!



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 1: Find ChatsTab by accessibility id: chats-stack-tab
    Device 1: Tap on found: ChatsTab 

    medium/test_activity_center.py:86: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(30)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_reactions, id: 703202

    Device 2: Looking for a message by text: This is a test message to check some reactions.
    Device 2: Find ChatElementByText by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/chats/test_group_chat.py:240: in test_group_chat_reactions
    self.chats[1].set_reaction(message=message, emoji="thumbs-up")
../views/chat_view.py:1020: in set_reaction
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:298: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:133: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 

    Test setup failed: critical/chats/test_1_1_public_chats.py:857: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:968: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 

    Test setup failed: critical/chats/test_1_1_public_chats.py:857: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:968: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784 

    Test setup failed: critical/chats/test_1_1_public_chats.py:857: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:968: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    4. test_1_1_chat_push_emoji, id: 702813 

    Test setup failed: critical/chats/test_1_1_public_chats.py:857: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:968: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 

    Test setup failed: critical/chats/test_1_1_public_chats.py:857: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:968: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 

    Test setup failed: critical/chats/test_1_1_public_chats.py:857: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:968: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    7. test_1_1_chat_edit_message, id: 702855 

    Test setup failed: critical/chats/test_1_1_public_chats.py:857: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:968: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    8. test_1_1_chat_send_image_save_and_share, id: 703391 

    Test setup failed: critical/chats/test_1_1_public_chats.py:857: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:968: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    9. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    10. test_1_1_chat_message_reaction, id: 702730

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'hey' 

    Test setup failed: critical/chats/test_1_1_public_chats.py:857: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:968: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Passed tests (22)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_mentions_push_notification, id: 702786
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_leave, id: 702845
    Device sessions

    12. test_community_unread_messages_badge, id: 702841
    Device sessions

    @churik churik self-assigned this Jul 24, 2023
    @churik
    Copy link
    Member

    churik commented Jul 24, 2023

    @mmilad75 please, resolve conflicts, thank you!

    @churik
    Copy link
    Member

    churik commented Jul 24, 2023 •
    edited
    Loading

    @Francesca-G can you please review this from the design perspective?
    Looks good to me from QA side.

    Francesca-G
    Francesca-G reviewed Jul 24, 2023
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Here's the Figma frame with the design review.

    I think at some point the Empty State copy changed so we have some updated ones, some that have a few mistakes (like full stops at the end) and some that are outdated and change from dark to light theme.
    So, to make it clear here is how the copy should be (from Campo, on Discord):

    The first line should always be: You're up to date

    The second line changes based on the selected tab:
    "All" tab: No unread notifications
    "Admin" tab: No unread admin notifications
    "Mentions" tab: No unread mention notifications
    "Replies" tab: No unread reply notifications to your messages
    "Contact requests" tab: No contact requests notifications
    "Identity verification" tab: No identity verification requests
    "Transactions" tab: No transaction notifications
    "Membership" tab: No membership notifications
    "System" tab: No system notifications

    With no full stops

    Hope this helps :)

    @churik
    Copy link
    Member

    churik commented Jul 24, 2023

    @mmilad75

    please move PR when it is ready to testing again, thanks!

    @mmilad75
    Notification Centre - add Empty Content screen
    4210aa5 
    resolve commit

refactor folders

resolve commits

fix lint issue
    @mmilad75 mmilad75 merged commit ec68002 into develop Jul 25, 2023
    2 checks passed
    @mmilad75 mmilad75 deleted the milad/16334 branch July 25, 2023 14:36
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ajayesivan ajayesivan ajayesivan approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    Assignees

    @churik churik

    @mmilad75 mmilad75

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Notification Centre - add Empty Content screen
    8 participants
    @mmilad75 @status-im-auto @churik @ajayesivan @smohamedjavid @J-Son89 @ibrkhalil @Francesca-G