Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discard backup message when recovering account #16748

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Jul 24, 2023

this PR aligned with PR

Testing notes

recovery account using keycard should works as before, pls attach debug logs if it works as before so i can check configuration passed correctly, thanks!

Platforms

  • Android
  • iOS

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jul 24, 2023

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
798018e #1 2023-07-24 04:15:42 ~3 min tests 📄log
✔️ 798018e #1 2023-07-24 04:21:32 ~9 min android-e2e 🤖apk 📲
✔️ 798018e #1 2023-07-24 04:21:37 ~8 min android 🤖apk 📲
✔️ 798018e #1 2023-07-24 04:23:15 ~10 min ios 📱ipa 📲
571e96a #2 2023-07-24 05:11:43 ~1 min tests 📄log
✔️ 571e96a #2 2023-07-24 05:16:24 ~6 min android-e2e 🤖apk 📲
✔️ 571e96a #2 2023-07-24 05:16:26 ~6 min android 🤖apk 📲
✔️ 571e96a #2 2023-07-24 05:17:56 ~7 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9517aa7 #3 2023-07-24 07:53:29 ~5 min android-e2e 🤖apk 📲
✔️ 9517aa7 #3 2023-07-24 07:55:37 ~7 min ios 📱ipa 📲
✔️ 9517aa7 #3 2023-07-24 07:58:37 ~10 min tests 📄log
✔️ 9517aa7 #3 2023-07-24 07:59:01 ~11 min android 🤖apk 📲
✔️ 9517aa7 #4 2023-07-25 06:45:08 ~7 min ios 📱ipa 📲
✔️ 6640d47 #6 2023-07-25 06:57:27 ~11 min ios 📱ipa 📲
✔️ 6640d47 #6 2023-07-25 06:57:31 ~11 min tests 📄log
✔️ 6640d47 #6 2023-07-25 06:58:23 ~11 min android-e2e 🤖apk 📲
✔️ 6640d47 #6 2023-07-25 06:58:25 ~12 min android 🤖apk 📲

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 36
Failed tests: 5
Passed tests: 31
Not executed tests: 3
IDs of not executed tests: 703496,703495,703382 
IDs of failed tests: 702732,703133,702851,702783,702731 

Not executed tests (3)

Click to expand
  • Rerun not executed tests
  • Failed tests (5)

    Click to expand
  • Rerun failed tests

  • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find `Text` by `xpath`: `//*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView`
    Device 2: `Text` is `Delivered`

    critical/chats/test_1_1_public_chats.py:1379: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
        self.errors.verify_no_errors()
    base_test_case.py:183: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Message was not delivered after resending from offline
    



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button

    critical/test_public_chat_browsing.py:433: in test_restore_multiaccount_with_waku_backup_remove_switch
        self.errors.verify_no_errors()
    base_test_case.py:183: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     admin_open was not restored from waku-backup!!
    E    member_open was not restored from waku-backup!!
    E    admin_closed was not restored from waku-backup!!
    E    member_closed was not restored from waku-backup!!
    E    Incorrect contacts number restored: 0 instead of 2
    E    Contact(s) was (were) not restored from backup: Test_contact, MyCustomNickname!
    



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Find Button by accessibility id: tab-contacts
    Device 2: Tap on found: Button

    medium/test_activity_center.py:111: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
        self.errors.verify_no_errors()
    base_test_case.py:183: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Contact was not added to contact list after accepting contact request (as receiver)
    E    Contact was not added to contact list after accepting contact request (as sender)
    



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (31)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    7. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_mentions_push_notification, id: 702786
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_leave, id: 702845
    Device sessions

    12. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    @qfrank qfrank force-pushed the fix/discard-backedup-messages-if-not-acc-recover-flow branch from 798018e to 571e96a Compare July 24, 2023 05:10
    @churik churik self-assigned this Jul 24, 2023
    @churik
    Copy link
    Member

    churik commented Jul 24, 2023

    Unfortuanately, the flow "recover with keycard" is not implemented in re-designed app, so I can't verify it.
    During check of "restore from seed phrase" flow one blocker is found

    ISSUE 1: unable to restore a multiaccount from seed on IOS

    Steps:

    1. restore the multiaccount from seed phrase

    Actual result:
    app is freezing on "Keys saved", after reopen:
    IMAGE 2023-07-24 15:18:46

    OS: IOS
    logs (51).zip

    @qfrank
    Copy link
    Contributor Author

    qfrank commented Jul 24, 2023

    Unfortuanately, the flow "recover with keycard" is not implemented in re-designed app, so I can't verify it. During check of "restore from seed phrase" flow one blocker is found

    ISSUE 1: unable to restore a multiaccount from seed on IOS

    Steps:

    1. restore the multiaccount from seed phrase

    Actual result: app is freezing on "Keys saved", after reopen: IMAGE 2023-07-24 15:18:46

    OS: IOS logs (51).zip

    Hi @churik , issue 1 should be relate to this commit id which include
    a migration , not relate to this PR cc @saledjenic

    @qfrank
    Copy link
    Contributor Author

    qfrank commented Jul 24, 2023

    if it's not implemented in re-designed app, maybe we can just merge it so that building status-mobile won't get blocked. but before merge it , we have to fix issue 1 , could you help take a look? @saledjenic or i may take a deep look tomorrow.

    @saledjenic
    Copy link

    @qfrank I haven't ever run the iOS app, don't have an environment set for it to check. For the desktop app all went well, also looking at this script cannot see anything problematic.

    @qfrank qfrank force-pushed the fix/discard-backedup-messages-if-not-acc-recover-flow branch from f32f64d to 6640d47 Compare July 25, 2023 06:46
    @qfrank qfrank merged commit 02d45fa into develop Jul 25, 2023
    2 checks passed
    @qfrank qfrank deleted the fix/discard-backedup-messages-if-not-acc-recover-flow branch July 25, 2023 07:03
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    6 participants