Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set initial block range for a newly created account (again) #16848

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Set initial block range for a newly created account (again) #16848

merged 1 commit into from
Aug 4, 2023

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Aug 2, 2023

status: ready

rasom
rasom commented Aug 2, 2023
View reviewed changes
src/status_im2/contexts/profile/login/events.cljs
(when (and creating? (not recovered-account?))
[:wallet/set-initial-blocks-range])]}
(if (or creating? recovered-account?)
(profile.create/login-new-profile recovered-account?)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like (profile.create/login-new-profile recovered-account?) was dead as both creating? and recovered-account? would be always nil nowadays, so I just removed it.

@status-im-auto
Copy link
Member

status-im-auto commented Aug 2, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (13)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 7000746 #1 2023-08-02 16:08:24 ~2 min tests 📄log
✔️ 7000746 #1 2023-08-02 16:11:59 ~6 min android 🤖apk 📲
✔️ 7000746 #1 2023-08-02 16:12:00 ~6 min android-e2e 🤖apk 📲
✔️ 7000746 #1 2023-08-02 16:15:27 ~10 min ios 📱ipa 📲
❌ 5801548 #2 2023-08-03 13:32:46 ~2 min tests 📄log
❌ d7e3c94 #3 2023-08-03 13:38:16 ~2 min tests 📄log
✔️ d7e3c94 #3 2023-08-03 13:40:57 ~5 min android 🤖apk 📲
✔️ d7e3c94 #3 2023-08-03 13:41:03 ~5 min android-e2e 🤖apk 📲
✔️ d7e3c94 #3 2023-08-03 13:45:04 ~9 min ios 📱ipa 📲
❌ 919888e #5 2023-08-04 12:57:20 ~2 min tests 📄log
✔️ 919888e #5 2023-08-04 13:01:27 ~6 min android-e2e 🤖apk 📲
✔️ 919888e #5 2023-08-04 13:01:29 ~6 min android 🤖apk 📲
✔️ 919888e #5 2023-08-04 13:03:02 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ c689354 #6 2023-08-04 13:35:16 ~2 min tests 📄log
✔️ c689354 #6 2023-08-04 13:38:22 ~5 min android 🤖apk 📲
✔️ c689354 #6 2023-08-04 13:38:32 ~5 min android-e2e 🤖apk 📲
✔️ c689354 #6 2023-08-04 13:40:59 ~8 min ios 📱ipa 📲
✔️ 18347b4 #7 2023-08-04 13:46:29 ~5 min android-e2e 🤖apk 📲
✔️ 18347b4 #7 2023-08-04 13:46:42 ~5 min android 🤖apk 📲
✔️ 18347b4 #7 2023-08-04 13:47:45 ~6 min ios 📱ipa 📲
✔️ 18347b4 #7 2023-08-04 13:49:26 ~8 min tests 📄log

@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 40
Failed tests: 4
Passed tests: 36
Not executed tests: 1

IDs of not executed tests: 702809 

IDs of failed tests: 702732,703133,703495,702731

Not executed tests (1)

Click to expand
  • Rerun not executed tests

    • Failed tests (4)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Restoring communities issue: 16787; restoring contacts issue: 15500]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chat name is not shown after unmute



    Device sessions

    Passed tests (36)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    8. test_1_1_chat_edit_message, id: 702855
    Device sessions

    9. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    10. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_mentions_push_notification, id: 702786
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_leave, id: 702845
    Device sessions

    12. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    @pavloburykh pavloburykh self-assigned this Aug 3, 2023
    @pavloburykh
    Copy link
    Contributor

    @rasom thanx for the PR!

    Please take a look at the following issue

    ISSUE 1 App crashes on recovery via seed phrase (Android)

    Steps:

    1. Proceed with recovering user via seed phrase
    2. Observe crash on Generating keys step

    Actual result: app crashes.

    In some cases different errors appearing:

    [5513,"RCTView",251,{"flexDirection":"row","marginHorizontal":"<<NaN>>","justifyContent":"space-between","marginBottom":16}] is not usable as a native method argument

    Status-debug-logs (44).zip

    Exception in HostFunction: Malformed calls from JS: field sizes are different.

[[2,2,2,2,2,2,2,2,2,2,2,2,2,26],[21,21,21,21,21,21,21,21,21,21,21,21,21,12],[[27,"RCTView",{"width":["window-width"]}],[39,"RCTView",{"width":["window-width"]}],[53,"RCTView",{"width":["window-width"]}],[69,"RCTView",{"width":["window-width"]}],[83,"RCTView",{"width":["window-width"]}],[95,"RCTView",{"width":["window-width"]}],[107,"RCTView",{"width":["window-width"]}],[1]],2571]

    Status-debug-logs (45).zip

    com.facebook.react.bridge.JSApplicationillegalArgumentException: Error while updating property 'width' in shadow node of type: RCTView

    photo_2023-08-03 15 25 17

    telegram-cloud-document-2-5359650965253271986.mp4

    Sometimes app crashes without any errors.

    @rasom
    Copy link
    Contributor Author

    rasom commented Aug 3, 2023

    @pavloburykh and none of this happened in develop before right? And iOS is fine?

    @rasom rasom force-pushed the fix/set-initial-range-for-a-new-account branch 2 times, most recently from 5801548 to d7e3c94 Compare August 3, 2023 13:34
    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Aug 3, 2023 •
    edited
    Loading

    @pavloburykh and none of this happened in develop before right? And iOS is fine?

    1. Have not faced those issues in develop
    2. IOS is not crashing but still it is not fine.

    As you can see on video, in case of IOS after keys generation step the rest 3 steps (identifiers, notifications, welcome screens) are skipped and user is being redirected right into account

    telegram-cloud-document-2-5359650965253272473.mp4

    @rasom
    Copy link
    Contributor Author

    rasom commented Aug 3, 2023

    @pavloburykh should be fixed now

    @status-im-auto
    Copy link
    Member

    93% of end-end tests have passed

    Total executed tests: 41
Failed tests: 3
Passed tests: 38

    IDs of failed tests: 702732,703133,702731

    Failed tests (3)

    Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Restoring communities issue: 16787; restoring contacts issue: 15500]]

    Passed tests (38)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    5. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    6. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    7. test_community_mentions_push_notification, id: 702786
    Device sessions

    8. test_community_message_delete, id: 702839
    Device sessions

    9. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    10. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    11. test_community_message_edit, id: 702843
    Device sessions

    12. test_community_leave, id: 702845
    Device sessions

    13. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    8. test_1_1_chat_edit_message, id: 702855
    Device sessions

    9. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    10. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @rasom ready for merge.

    @rasom rasom force-pushed the fix/set-initial-range-for-a-new-account branch 3 times, most recently from 919888e to c689354 Compare August 4, 2023 13:32
    @rasom rasom force-pushed the fix/set-initial-range-for-a-new-account branch from c689354 to 18347b4 Compare August 4, 2023 13:40
    @rasom rasom merged commit 18347b4 into develop Aug 4, 2023
    2 checks passed
    @rasom rasom deleted the fix/set-initial-range-for-a-new-account branch August 4, 2023 14:02
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @rasom rasom

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @rasom @status-im-auto @pavloburykh @flexsurfer @ibrkhalil