Fix for Android error route ip+net: netlinkrib: permission denied
#17166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (34)
|
|
Hey @status-im/on-call there seems to be something weird going on with this PR, it keeps failing to build for Android |
|
Follow up on the Android build failure, the root |
|
@Samyoul |
qfrank
approved these changes
Sep 4, 2023
qfrank
force-pushed
the
fix/android-net-permissions
branch
from
d9449e0
to
4d8af58
Compare
|
@qfrank @qfrank can you please recheck whether it is the same #17137 (comment) or #16987 ? should I report it separately or add info to existing issues? |
they are the same @churik |
Samyoul
force-pushed
the
fix/android-net-permissions
branch
from
4d8af58
to
7058c29
Compare
|
@churik I've pushed an updated version using the commit hash as the target. I didn't realise that targeting PR number would cause a problem with the build... Well we'll see what happens |
Hi @Samyoul , welcome back! Your PR on status-go side seems not work according their test result (I've updated status-go-version.go to point to your status-go PR before) .. |
|
@qfrank Logs: |
qfrank
force-pushed
the
fix/android-net-permissions
branch
from
7058c29
to
2658041
Compare
|
Hi @churik , pls let me know if the new commit works for you, thank you! cc @pavloburykh @VolodLytvynenko |
63% of end-end tests have passedFailed tests (16)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (27)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
|
|
@qfrank |
Hi @churik , would you mind retry using release version of desktop which use status-go v0.164.0 ? because the test get passed with my last commit in my local machine using android emulator, but the issue can be reproduced without my last commit |
Hi @qfrank I'm still unable to sync using Android and IOS, even when trying to sync with the release desktop where status go is v0.164.0. Actual result:
Untitled.mp4Device:
Logs: |
|
emm... cc @Samyoul |
|
@qfrank Just wanted to collect logs from iOS, but it seems this issue is not reproducible for me anymore. I've successfully synced with the desktop, and the same goes for Android. I will investigate it and let you know if it happens again. |
|
I'll try last builds too with desktop master and desktop RC. |
|
@Samyoul @qfrank One question: Did I understand correctly that the scope of this PR is to fix only the happy path, which includes:
I'm asking because there is an additional issue: the iOS app always crashes after the initial QR code syncing. However, when the app is reopened, the synced account is already displayed and able to be logged in Steps
Actual result:The app crashes on IOS during sync process (but as result the account is synced) ioscrash.mp4Logs:Status.log Device:iPhone 11 Pro max, IOS 16 |
@VolodLytvynenko yes, it is reproducible for me too |
51% of end-end tests have passedFailed tests (21)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (22)Click to expandClass TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
|
@VolodLytvynenko @qfrank If there is no option to fix crash mentioned #17166 (comment) quite fast, I believe it would be better to merge current PR |
agreed, not that easy to reproduce using xcode, but it can be reproduced with PR build in 100%, i need to find out the difference between xcode build and PR build. cc @Samyoul |
|
Ok, I'll merge status-im/status-go#3982 as this does fix a set of problems. I do have this PR #16694 which is trying to / has already fixed some other pairing issues that seem related to double scanning a QR code. |
Ok, this sounds like another problem though with iOS. Where iOS syncs but returns an error after the process has completed Or one of the end pairing processes fail. |
I will create a separate issue for this with xcode logs if they are helpful |
79% of end-end tests have passedFailed tests (9)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (34)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
qfrank
force-pushed
the
fix/android-net-permissions
branch
from
cbe4450
to
ec47851
Compare
|
Oh, i made a mistake... i saw @Samyoul changed file VERSION to |
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile build of status-im/status-go#3982
Resolved #17156